Title: [260727] trunk/Source/WTF
Revision
260727
Author
[email protected]
Date
2020-04-26 11:55:20 -0700 (Sun, 26 Apr 2020)

Log Message

[WTF] Workaround gcc bug for unsigned bitfield related usual arithmetic conversions
https://bugs.webkit.org/show_bug.cgi?id=211044

Reviewed by Darin Adler.

* wtf/URL.cpp:
(WTF::URL::setHost):
(WTF::URL::setHostAndPort):
(WTF::URL::setUser):
(WTF::URL::setPassword):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (260726 => 260727)


--- trunk/Source/WTF/ChangeLog	2020-04-26 16:34:24 UTC (rev 260726)
+++ trunk/Source/WTF/ChangeLog	2020-04-26 18:55:20 UTC (rev 260727)
@@ -1,3 +1,16 @@
+2020-04-26  Joonghun Park  <[email protected]>
+
+        [WTF] Workaround gcc bug for unsigned bitfield related usual arithmetic conversions
+        https://bugs.webkit.org/show_bug.cgi?id=211044
+
+        Reviewed by Darin Adler.
+
+        * wtf/URL.cpp:
+        (WTF::URL::setHost):
+        (WTF::URL::setHostAndPort):
+        (WTF::URL::setUser):
+        (WTF::URL::setPassword):
+
 2020-04-25  Joonghun Park  <[email protected]>
 
         Unreviewed. Remove the bulid warnings below since r260707.

Modified: trunk/Source/WTF/wtf/URL.cpp (260726 => 260727)


--- trunk/Source/WTF/wtf/URL.cpp	2020-04-26 16:34:24 UTC (rev 260726)
+++ trunk/Source/WTF/wtf/URL.cpp	2020-04-26 18:55:20 UTC (rev 260727)
@@ -436,7 +436,7 @@
     if (!appendEncodedHostname(encodedHostName, newHost))
         return;
 
-    bool slashSlashNeeded = m_userStart == static_cast<unsigned>(m_schemeEnd + 1);
+    bool slashSlashNeeded = m_userStart == m_schemeEnd + 1U;
     parse(makeString(
         StringView(m_string).left(hostStart()),
         slashSlashNeeded ? "//" : "",
@@ -486,7 +486,7 @@
     if (!appendEncodedHostname(encodedHostName, hostName))
         return;
 
-    bool slashSlashNeeded = m_userStart == static_cast<unsigned>(m_schemeEnd + 1);
+    bool slashSlashNeeded = m_userStart == m_schemeEnd + 1U;
     parse(makeString(
         StringView(m_string).left(hostStart()),
         slashSlashNeeded ? "//" : "",
@@ -547,7 +547,7 @@
 
     unsigned end = m_userEnd;
     if (!newUser.isEmpty()) {
-        bool slashSlashNeeded = m_userStart == static_cast<unsigned>(m_schemeEnd + 1);
+        bool slashSlashNeeded = m_userStart == m_schemeEnd + 1U;
         bool needSeparator = end == m_hostEnd || (end == m_passwordEnd && m_string[end] != '@');
         parse(makeString(
             StringView(m_string).left(m_userStart),
@@ -570,7 +570,7 @@
         return;
 
     if (!newPassword.isEmpty()) {
-        bool needLeadingSlashes = m_userEnd == static_cast<unsigned>(m_schemeEnd + 1);
+        bool needLeadingSlashes = m_userEnd == m_schemeEnd + 1U;
         parse(makeString(
             StringView(m_string).left(m_userEnd),
             needLeadingSlashes ? "//:" : ":",
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to