Title: [260926] trunk/Tools
- Revision
- 260926
- Author
- [email protected]
- Date
- 2020-04-29 16:42:05 -0700 (Wed, 29 Apr 2020)
Log Message
Add better handling of an uncleared bundle identifier in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=211195
<rdar://problem/62117145>
Reviewed by Alexey Proskuryakov.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (260925 => 260926)
--- trunk/Tools/ChangeLog 2020-04-29 23:37:44 UTC (rev 260925)
+++ trunk/Tools/ChangeLog 2020-04-29 23:42:05 UTC (rev 260926)
@@ -1,3 +1,14 @@
+2020-04-29 Kate Cheney <[email protected]>
+
+ Add better handling of an uncleared bundle identifier in WebKitTestRunner
+ https://bugs.webkit.org/show_bug.cgi?id=211195
+ <rdar://problem/62117145>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::createWebViewWithOptions):
+
2020-04-29 Saam Barati <[email protected]>
build-jsc should quote the value of compile flags it forwards
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (260925 => 260926)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-04-29 23:37:44 UTC (rev 260925)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-04-29 23:42:05 UTC (rev 260926)
@@ -640,11 +640,9 @@
void TestController::createWebViewWithOptions(const TestOptions& options)
{
#if PLATFORM(COCOA)
- if (m_hasSetApplicationBundleIdentifier) {
- // Exit if the application bundle identifier has already been set, since it can only be set once.
- exit(1);
- }
if (!options.applicationBundleIdentifier.isEmpty()) {
+ // The bundle identifier can only be set once per test, and is cleared between tests.
+ RELEASE_ASSERT(!m_hasSetApplicationBundleIdentifier);
setApplicationBundleIdentifier(options.applicationBundleIdentifier);
m_hasSetApplicationBundleIdentifier = true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
