Title: [261020] trunk/Source/WebKit
- Revision
- 261020
- Author
- drou...@apple.com
- Date
- 2020-05-01 14:09:52 -0700 (Fri, 01 May 2020)
Log Message
Web Inspector: Browser: crash when handling `disable`
https://bugs.webkit.org/show_bug.cgi?id=211251
Reviewed by Daniel Bates.
* UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp:
(WebKit::InspectorBrowserAgent::disable):
If the inspected page crashed, we won't have a `WebInspectorProxy` anymore.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (261019 => 261020)
--- trunk/Source/WebKit/ChangeLog 2020-05-01 20:53:59 UTC (rev 261019)
+++ trunk/Source/WebKit/ChangeLog 2020-05-01 21:09:52 UTC (rev 261020)
@@ -1,3 +1,14 @@
+2020-05-01 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: Browser: crash when handling `disable`
+ https://bugs.webkit.org/show_bug.cgi?id=211251
+
+ Reviewed by Daniel Bates.
+
+ * UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp:
+ (WebKit::InspectorBrowserAgent::disable):
+ If the inspected page crashed, we won't have a `WebInspectorProxy` anymore.
+
2020-05-01 Per Arne Vollan <pvol...@apple.com>
[iOS] Every running WebContent process should be granted access to frontboard services when Accessibility is enabled
Modified: trunk/Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp (261019 => 261020)
--- trunk/Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp 2020-05-01 20:53:59 UTC (rev 261019)
+++ trunk/Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp 2020-05-01 21:09:52 UTC (rev 261020)
@@ -87,9 +87,8 @@
m_inspectedPage.inspectorController().setEnabledInspectorBrowserAgent(nullptr);
- auto* inspector = m_inspectedPage.inspector();
- ASSERT(inspector);
- m_inspectedPage.inspectorClient().browserDomainDisabled(m_inspectedPage, *inspector);
+ if (auto* inspector = m_inspectedPage.inspector())
+ m_inspectedPage.inspectorClient().browserDomainDisabled(m_inspectedPage, *inspector);
}
void InspectorBrowserAgent::extensionsEnabled(HashMap<String, String>&& extensionIDToName)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
