Title: [261068] trunk/Tools
- Revision
- 261068
- Author
- [email protected]
- Date
- 2020-05-03 15:14:45 -0700 (Sun, 03 May 2020)
Log Message
[iPad Simulator] TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder is failing
https://bugs.webkit.org/show_bug.cgi?id=208281
<rdar://problem/59829265>
Reviewed by Wenson Hsieh.
I tried to write the test SelectPositionAtPointAfterBecomingFirstResponder for both iPad and iPhone,
but it turns out that I forgot an impl detail on how form control dismissal works for iPad and fixing
this would require adding more SPI/IPI. This is largely due to differences in form control UI and
conventions for dismissing such UI. This test isn't testing such UI it just needs to ensure that the
view is not first responder before it runs the actual test code. It uses an iPhone specific set of
steps to do this. It's enough to test this functionality on iPhone.
* TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (261067 => 261068)
--- trunk/Tools/ChangeLog 2020-05-03 22:00:48 UTC (rev 261067)
+++ trunk/Tools/ChangeLog 2020-05-03 22:14:45 UTC (rev 261068)
@@ -1,5 +1,23 @@
2020-05-03 Daniel Bates <[email protected]>
+ [iPad Simulator] TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder is failing
+ https://bugs.webkit.org/show_bug.cgi?id=208281
+ <rdar://problem/59829265>
+
+ Reviewed by Wenson Hsieh.
+
+ I tried to write the test SelectPositionAtPointAfterBecomingFirstResponder for both iPad and iPhone,
+ but it turns out that I forgot an impl detail on how form control dismissal works for iPad and fixing
+ this would require adding more SPI/IPI. This is largely due to differences in form control UI and
+ conventions for dismissing such UI. This test isn't testing such UI it just needs to ensure that the
+ view is not first responder before it runs the actual test code. It uses an iPhone specific set of
+ steps to do this. It's enough to test this functionality on iPhone.
+
+ * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
+ (TEST):
+
+2020-05-03 Daniel Bates <[email protected]>
+
Update info.
* Scripts/webkitpy/common/config/contributors.json:
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm (261067 => 261068)
--- trunk/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm 2020-05-03 22:00:48 UTC (rev 261067)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm 2020-05-03 22:14:45 UTC (rev 261068)
@@ -31,6 +31,7 @@
#import "TestInputDelegate.h"
#import "TestWKWebView.h"
#import "UIKitSPI.h"
+#import "UserInterfaceSwizzler.h"
#import <WebKit/WKWebViewPrivate.h>
#import <WebKit/WKWebViewPrivateForTesting.h>
#import <wtf/RetainPtr.h>
@@ -107,6 +108,8 @@
TEST(UIWKInteractionViewProtocol, SelectPositionAtPointAfterBecomingFirstResponder)
{
+ IPhoneUserInterfaceSwizzler userInterfaceSwizzler;
+
auto inputDelegate = adoptNS([TestInputDelegate new]);
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)]);
[webView _setInputDelegate:inputDelegate.get()];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
