Title: [261197] trunk/Source/WebInspectorUI
- Revision
- 261197
- Author
- drou...@apple.com
- Date
- 2020-05-05 14:00:52 -0700 (Tue, 05 May 2020)
Log Message
Web Inspector: Timelines: Memory: the stacked area graph should not extend beyond the "stopping time" marker
https://bugs.webkit.org/show_bug.cgi?id=211327
Reviewed by Brian Burg.
* UserInterface/Views/MemoryTimelineOverviewGraph.js:
(WI.MemoryTimelineOverviewGraph.prototype.layout):
(WI.MemoryTimelineOverviewGraph.prototype.layout.insertDiscontinuity):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (261196 => 261197)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-05-05 20:52:15 UTC (rev 261196)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-05-05 21:00:52 UTC (rev 261197)
@@ -1,5 +1,16 @@
2020-05-05 Devin Rousso <drou...@apple.com>
+ Web Inspector: Timelines: Memory: the stacked area graph should not extend beyond the "stopping time" marker
+ https://bugs.webkit.org/show_bug.cgi?id=211327
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/MemoryTimelineOverviewGraph.js:
+ (WI.MemoryTimelineOverviewGraph.prototype.layout):
+ (WI.MemoryTimelineOverviewGraph.prototype.layout.insertDiscontinuity):
+
+2020-05-05 Devin Rousso <drou...@apple.com>
+
Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'this.InspectorAgent.initialized')
https://bugs.webkit.org/show_bug.cgi?id=211434
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js (261196 => 261197)
--- trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js 2020-05-05 20:52:15 UTC (rev 261196)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js 2020-05-05 21:00:52 UTC (rev 261197)
@@ -165,7 +165,7 @@
if (!(previousRecord || nextRecord))
return;
- let xStart = xScale(startDiscontinuity.startTime);
+ let xStart = xScale(previousRecord ? previousRecord.endTime : startDiscontinuity.startTime);
let xEnd = xScale(endDiscontinuity.endTime);
// Extend the previous record to the start of the discontinuity.
@@ -208,7 +208,7 @@
// Extend the last value to current / end time.
let lastRecord = visibleRecords.lastValue;
if (lastRecord.startTime <= visibleEndTime) {
- let x = Math.floor(xScale(visibleEndTime));
+ let x = Math.floor(xScale(lastRecord.endTime));
this._chart.addPointSet(x, pointSetForRecord(lastRecord));
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
