Title: [261287] trunk/Tools
- Revision
- 261287
- Author
- commit-qu...@webkit.org
- Date
- 2020-05-07 07:47:04 -0700 (Thu, 07 May 2020)
Log Message
[Flatpak SDK] Doesn't generate crash logs on the bots
https://bugs.webkit.org/show_bug.cgi?id=211568
Patch by Philippe Normand <pnorm...@igalia.com> on 2020-05-07
Reviewed by Carlos Alberto Lopez Perez.
* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): Bind-mount the
WEBKIT_CORE_DUMPS_DIRECTORY so that the crash-log generator is
able to write crash log reports there.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (261286 => 261287)
--- trunk/Tools/ChangeLog 2020-05-07 14:37:35 UTC (rev 261286)
+++ trunk/Tools/ChangeLog 2020-05-07 14:47:04 UTC (rev 261287)
@@ -1,3 +1,15 @@
+2020-05-07 Philippe Normand <pnorm...@igalia.com>
+
+ [Flatpak SDK] Doesn't generate crash logs on the bots
+ https://bugs.webkit.org/show_bug.cgi?id=211568
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ * flatpak/flatpakutils.py:
+ (WebkitFlatpak.run_in_sandbox): Bind-mount the
+ WEBKIT_CORE_DUMPS_DIRECTORY so that the crash-log generator is
+ able to write crash log reports there.
+
2020-05-07 Truitt Savell <tsav...@apple.com>
Unskip the test since it should now be passing
Modified: trunk/Tools/flatpak/flatpakutils.py (261286 => 261287)
--- trunk/Tools/flatpak/flatpakutils.py 2020-05-07 14:37:35 UTC (rev 261286)
+++ trunk/Tools/flatpak/flatpakutils.py 2020-05-07 14:47:04 UTC (rev 261287)
@@ -700,6 +700,10 @@
else:
_log.debug("Can't find user document path at '{uid_doc_path}'. Not mounting it.".format(uid_doc_path=uid_doc_path))
+ coredumps_dir = os.environ.get("WEBKIT_CORE_DUMPS_DIRECTORY")
+ if coredumps_dir and os.path.isdir(coredumps_dir):
+ flatpak_command.append("--bind-mount={coredumps_dir}={coredumps_dir}".format(coredumps_dir))
+
sandbox_environment.update({
"TZ": "PST8PDT",
"LANG": "en_US.UTF-8",
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
