Title: [261338] trunk/Source/WebCore
Revision
261338
Author
shihchieh_...@apple.com
Date
2020-05-07 15:58:14 -0700 (Thu, 07 May 2020)

Log Message

In Document::willBeRemovedFromFrame, clear FrameSelection before Editor so the selection is removed.
https://bugs.webkit.org/show_bug.cgi?id=211551

Reviewed by Geoffrey Garen.

Covered by existing tests.

* dom/Document.cpp:
(WebCore::Document::willBeRemovedFromFrame):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (261337 => 261338)


--- trunk/Source/WebCore/ChangeLog	2020-05-07 21:48:13 UTC (rev 261337)
+++ trunk/Source/WebCore/ChangeLog	2020-05-07 22:58:14 UTC (rev 261338)
@@ -1,3 +1,15 @@
+2020-05-07  Jack Lee  <shihchieh_...@apple.com>
+
+        In Document::willBeRemovedFromFrame, clear FrameSelection before Editor so the selection is removed.
+        https://bugs.webkit.org/show_bug.cgi?id=211551
+
+        Reviewed by Geoffrey Garen.
+
+        Covered by existing tests.
+
+        * dom/Document.cpp:
+        (WebCore::Document::willBeRemovedFromFrame):
+
 2020-05-07  Antoine Quint  <grao...@apple.com>
 
         [Web Animations] imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html is a flaky failure

Modified: trunk/Source/WebCore/dom/Document.cpp (261337 => 261338)


--- trunk/Source/WebCore/dom/Document.cpp	2020-05-07 21:48:13 UTC (rev 261337)
+++ trunk/Source/WebCore/dom/Document.cpp	2020-05-07 22:58:14 UTC (rev 261338)
@@ -2596,8 +2596,8 @@
         page()->updateIsPlayingMedia(HTMLMediaElementInvalidID);
     }
 
+    selection().willBeRemovedFromFrame();
     editor().clear();
-    selection().willBeRemovedFromFrame();
     detachFromFrame();
 
 #if ENABLE(CSS_PAINTING_API)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to