Title: [261385] trunk/Source/WebCore
- Revision
- 261385
- Author
- andresg...@apple.com
- Date
- 2020-05-08 09:17:55 -0700 (Fri, 08 May 2020)
Log Message
Fix for crashes in LayoutTests in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=211622
Reviewed by Chris Fleizach.
Several LayoutTests.
Return the root from the isolated tree when it is really ready.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rootObject):
Some code cleanup.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clickPoint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (261384 => 261385)
--- trunk/Source/WebCore/ChangeLog 2020-05-08 15:39:39 UTC (rev 261384)
+++ trunk/Source/WebCore/ChangeLog 2020-05-08 16:17:55 UTC (rev 261385)
@@ -1,3 +1,20 @@
+2020-05-08 Andres Gonzalez <andresg...@apple.com>
+
+ Fix for crashes in LayoutTests in isolated tree mode.
+ https://bugs.webkit.org/show_bug.cgi?id=211622
+
+ Reviewed by Chris Fleizach.
+
+ Several LayoutTests.
+
+ Return the root from the isolated tree when it is really ready.
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::rootObject):
+
+ Some code cleanup.
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::clickPoint):
+
2020-05-08 Simon Fraser <simon.fra...@apple.com>
Overflow scrollers in iframes don't get mouseMovedInContentArea()
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (261384 => 261385)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2020-05-08 15:39:39 UTC (rev 261384)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2020-05-08 16:17:55 UTC (rev 261385)
@@ -714,7 +714,7 @@
return nullptr;
#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
- if (clientSupportsIsolatedTree())
+ if (isIsolatedTreeEnabled())
return isolatedTreeRootObject();
#endif
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (261384 => 261385)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2020-05-08 15:39:39 UTC (rev 261384)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2020-05-08 16:17:55 UTC (rev 261385)
@@ -925,9 +925,8 @@
IntPoint AccessibilityRenderObject::clickPoint()
{
// Headings are usually much wider than their textual content. If the mid point is used, often it can be wrong.
- AccessibilityChildrenVector children = this->children();
- if (isHeading() && children.size() == 1)
- return children[0]->clickPoint();
+ if (isHeading() && children().size() == 1)
+ return children().first()->clickPoint();
if (isLink())
return linkClickPoint();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
