Title: [261400] trunk/Source/WebCore
- Revision
- 261400
- Author
- commit-qu...@webkit.org
- Date
- 2020-05-08 11:36:32 -0700 (Fri, 08 May 2020)
Log Message
SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN
https://bugs.webkit.org/show_bug.cgi?id=211539
Patch by Pinki Gyanchandani <pgyanchand...@apple.com> on 2020-05-08
Reviewed by Simon Fraser.
Corrected the comment.
No new test needed.
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createRasterShape):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (261399 => 261400)
--- trunk/Source/WebCore/ChangeLog 2020-05-08 17:57:54 UTC (rev 261399)
+++ trunk/Source/WebCore/ChangeLog 2020-05-08 18:36:32 UTC (rev 261400)
@@ -1,3 +1,17 @@
+2020-05-08 Pinki Gyanchandani <pgyanchand...@apple.com>
+
+ SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN
+ https://bugs.webkit.org/show_bug.cgi?id=211539
+
+ Reviewed by Simon Fraser.
+
+ Corrected the comment.
+
+ No new test needed.
+
+ * rendering/shapes/Shape.cpp:
+ (WebCore::Shape::createRasterShape):
+
2020-05-08 Rob Buis <rb...@igalia.com>
Fix urlsearchparams-delete.html
Modified: trunk/Source/WebCore/rendering/shapes/Shape.cpp (261399 => 261400)
--- trunk/Source/WebCore/rendering/shapes/Shape.cpp 2020-05-08 17:57:54 UTC (rev 261399)
+++ trunk/Source/WebCore/rendering/shapes/Shape.cpp 2020-05-08 18:36:32 UTC (rev 261400)
@@ -199,9 +199,8 @@
auto imageData = imageBuffer->getImageData(AlphaPremultiplication::Unpremultiplied, { IntPoint(), imageRect.size() });
- // Removing the Release Assert, as we could get to a value where imageData could be nullptr. A case where
- // ImageRect.size() is huge, imageData::create can return a nullptr because data size has overflowed.
- // Refer rdar://problem/61793884
+ // We could get to a value where imageData could be nullptr. A case where ImageRect.size() is huge, imageData::create
+ // can return a nullptr because data size has overflowed. Refer rdar://problem/61793884
if (!imageData || !imageData->data())
return createShape();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
