Title: [261535] trunk/Source/WebCore
- Revision
- 261535
- Author
- simon.fra...@apple.com
- Date
- 2020-05-11 18:05:57 -0700 (Mon, 11 May 2020)
Log Message
Scrollbars flicker in RTL scrollable regions
https://bugs.webkit.org/show_bug.cgi?id=211757
Reviewed by Tim Horton.
Scrollbars deal in scroll offsets (zero-based), not scroll positions (scroll-origin based) so
the scrolling thread needs to update scrollbar painters using offsets.
Not testable because this is a transient state that gets fixed by the main thread.
* page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::updateScrollbarPainters):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (261534 => 261535)
--- trunk/Source/WebCore/ChangeLog 2020-05-12 00:38:36 UTC (rev 261534)
+++ trunk/Source/WebCore/ChangeLog 2020-05-12 01:05:57 UTC (rev 261535)
@@ -1,3 +1,18 @@
+2020-05-11 Simon Fraser <simon.fra...@apple.com>
+
+ Scrollbars flicker in RTL scrollable regions
+ https://bugs.webkit.org/show_bug.cgi?id=211757
+
+ Reviewed by Tim Horton.
+
+ Scrollbars deal in scroll offsets (zero-based), not scroll positions (scroll-origin based) so
+ the scrolling thread needs to update scrollbar painters using offsets.
+
+ Not testable because this is a transient state that gets fixed by the main thread.
+
+ * page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
+ (WebCore::ScrollingTreeScrollingNodeDelegateMac::updateScrollbarPainters):
+
2020-05-11 Ben Nham <n...@apple.com>
Improve accuracy of IndexedDB estimated write size computation
Modified: trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm (261534 => 261535)
--- trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm 2020-05-12 00:38:36 UTC (rev 261534)
+++ trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm 2020-05-12 01:05:57 UTC (rev 261535)
@@ -376,7 +376,7 @@
void ScrollingTreeScrollingNodeDelegateMac::updateScrollbarPainters()
{
if (m_verticalScrollerImp || m_horizontalScrollerImp) {
- auto scrollPosition = currentScrollPosition();
+ auto scrollOffset = scrollingNode().currentScrollOffset();
[CATransaction begin];
[CATransaction lock];
@@ -384,7 +384,7 @@
if ([m_verticalScrollerImp shouldUsePresentationValue]) {
float presentationValue;
float overhangAmount;
- ScrollableArea::computeScrollbarValueAndOverhang(scrollPosition.y(), totalContentsSize().height(), scrollableAreaSize().height(), presentationValue, overhangAmount);
+ ScrollableArea::computeScrollbarValueAndOverhang(scrollOffset.y(), totalContentsSize().height(), scrollableAreaSize().height(), presentationValue, overhangAmount);
[m_verticalScrollerImp setPresentationValue:presentationValue];
}
@@ -391,7 +391,7 @@
if ([m_horizontalScrollerImp shouldUsePresentationValue]) {
float presentationValue;
float overhangAmount;
- ScrollableArea::computeScrollbarValueAndOverhang(scrollPosition.x(), totalContentsSize().width(), scrollableAreaSize().width(), presentationValue, overhangAmount);
+ ScrollableArea::computeScrollbarValueAndOverhang(scrollOffset.x(), totalContentsSize().width(), scrollableAreaSize().width(), presentationValue, overhangAmount);
[m_horizontalScrollerImp setPresentationValue:presentationValue];
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
