Title: [261691] trunk/Source/WebCore
- Revision
- 261691
- Author
- andresg...@apple.com
- Date
- 2020-05-14 08:29:05 -0700 (Thu, 14 May 2020)
Log Message
Implementation of AXIsolatedObject::hasPlainText.
https://bugs.webkit.org/show_bug.cgi?id=211892
Reviewed by Chris Fleizach.
Covered by existing tests.
Adding hasPlainText to the cached properties map.
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::hasPlainText const): Deleted, inlined in header.
* accessibility/isolatedtree/AXIsolatedObject.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (261690 => 261691)
--- trunk/Source/WebCore/ChangeLog 2020-05-14 14:46:08 UTC (rev 261690)
+++ trunk/Source/WebCore/ChangeLog 2020-05-14 15:29:05 UTC (rev 261691)
@@ -1,3 +1,19 @@
+2020-05-14 Andres Gonzalez <andresg...@apple.com>
+
+ Implementation of AXIsolatedObject::hasPlainText.
+ https://bugs.webkit.org/show_bug.cgi?id=211892
+
+ Reviewed by Chris Fleizach.
+
+ Covered by existing tests.
+
+ Adding hasPlainText to the cached properties map.
+
+ * accessibility/isolatedtree/AXIsolatedObject.cpp:
+ (WebCore::AXIsolatedObject::initializeAttributeData):
+ (WebCore::AXIsolatedObject::hasPlainText const): Deleted, inlined in header.
+ * accessibility/isolatedtree/AXIsolatedObject.h:
+
2020-05-14 Sergio Villar Senin <svil...@igalia.com>
Unreviewed build fix.
Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp (261690 => 261691)
--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp 2020-05-14 14:46:08 UTC (rev 261690)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp 2020-05-14 15:29:05 UTC (rev 261691)
@@ -220,6 +220,7 @@
setProperty(AXPropertyName::HasHighlighting, object.hasHighlighting());
setProperty(AXPropertyName::HasBoldFont, object.hasBoldFont());
setProperty(AXPropertyName::HasItalicFont, object.hasItalicFont());
+ setProperty(AXPropertyName::HasPlainText, object.hasPlainText());
setProperty(AXPropertyName::IsKeyboardFocusable, object.isKeyboardFocusable());
if (object.isTable()) {
@@ -1198,12 +1199,6 @@
return false;
}
-bool AXIsolatedObject::hasPlainText() const
-{
- ASSERT_NOT_REACHED();
- return false;
-}
-
bool AXIsolatedObject::hasSameFont(RenderObject*) const
{
ASSERT_NOT_REACHED();
Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h (261690 => 261691)
--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h 2020-05-14 14:46:08 UTC (rev 261690)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h 2020-05-14 15:29:05 UTC (rev 261691)
@@ -151,6 +151,7 @@
HasChildren,
HasHighlighting,
HasItalicFont,
+ HasPlainText,
HasPopup,
HeaderContainer,
HeadingLevel,
@@ -763,7 +764,7 @@
bool hasBoldFont() const override { return boolAttributeValue(AXPropertyName::HasBoldFont); }
bool hasItalicFont() const override { return boolAttributeValue(AXPropertyName::HasItalicFont); }
bool hasMisspelling() const override;
- bool hasPlainText() const override;
+ bool hasPlainText() const override { return boolAttributeValue(AXPropertyName::HasPlainText); }
bool hasSameFont(RenderObject*) const override;
bool hasSameFontColor(RenderObject*) const override;
bool hasSameStyle(RenderObject*) const override;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
