Title: [261737] trunk/Source/_javascript_Core
- Revision
- 261737
- Author
- pma...@igalia.com
- Date
- 2020-05-15 01:58:22 -0700 (Fri, 15 May 2020)
Log Message
Fix ARM NEON only assert
https://bugs.webkit.org/show_bug.cgi?id=211889
Reviewed by Mark Lam.
Fix assert that breaks if ARM does not contain NEON extensions -
the register d16 is only defined if NEON exists.
* assembler/ARMv7Assembler.h:
(JSC::RegisterNames::asSingle):
(JSC::RegisterNames::asSingleUpper):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (261736 => 261737)
--- trunk/Source/_javascript_Core/ChangeLog 2020-05-15 08:54:47 UTC (rev 261736)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-05-15 08:58:22 UTC (rev 261737)
@@ -1,3 +1,17 @@
+2020-05-15 Paulo Matos <pma...@igalia.com>
+
+ Fix ARM NEON only assert
+ https://bugs.webkit.org/show_bug.cgi?id=211889
+
+ Reviewed by Mark Lam.
+
+ Fix assert that breaks if ARM does not contain NEON extensions -
+ the register d16 is only defined if NEON exists.
+
+ * assembler/ARMv7Assembler.h:
+ (JSC::RegisterNames::asSingle):
+ (JSC::RegisterNames::asSingleUpper):
+
2020-05-14 Saam Barati <sbar...@apple.com>
GetByVal and PutByVal runtime operations shouldn't fall off a performance cliff when the property is an integer boxed as a double
Modified: trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h (261736 => 261737)
--- trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2020-05-15 08:54:47 UTC (rev 261736)
+++ trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2020-05-15 08:58:22 UTC (rev 261737)
@@ -80,13 +80,13 @@
inline FPSingleRegisterID asSingle(FPDoubleRegisterID reg)
{
- ASSERT(reg < d16);
+ ASSERT(reg <= d15);
return (FPSingleRegisterID)(reg << 1);
}
inline FPSingleRegisterID asSingleUpper(FPDoubleRegisterID reg)
{
- ASSERT(reg < d16);
+ ASSERT(reg <= d15);
return (FPSingleRegisterID)((reg << 1) + 1);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
