Title: [104306] trunk
- Revision
- 104306
- Author
- [email protected]
- Date
- 2012-01-06 11:38:46 -0800 (Fri, 06 Jan 2012)
Log Message
Fullscreen video controller can't be dragged the first time I enter fullscreen
https://bugs.webkit.org/show_bug.cgi?id=75709
Reviewed by Eric Carlson.
Source/WebCore:
No new tests; updated video-controls-drag.html.
When the media controls are created, check to see if we are full screen, and pass
that information to the newly created controls.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createMediaControls):
LayoutTests:
Update the test to cover the case where the controls do not yet exist when entering
fullscreen.
* fullscreen/video-controls-drag.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (104305 => 104306)
--- trunk/LayoutTests/ChangeLog 2012-01-06 19:30:16 UTC (rev 104305)
+++ trunk/LayoutTests/ChangeLog 2012-01-06 19:38:46 UTC (rev 104306)
@@ -1,3 +1,15 @@
+2012-01-06 Jer Noble <[email protected]>
+
+ Fullscreen video controller can't be dragged the first time I enter fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=75709
+
+ Reviewed by Eric Carlson.
+
+ Update the test to cover the case where the controls do not yet exist when entering
+ fullscreen.
+
+ * fullscreen/video-controls-drag.html:
+
2012-01-06 Jon Lee <[email protected]>
Update test expectations with rebaseline of fast/forms/listbox-clip.html from r104299.
Modified: trunk/LayoutTests/fullscreen/video-controls-drag.html (104305 => 104306)
--- trunk/LayoutTests/fullscreen/video-controls-drag.html 2012-01-06 19:30:16 UTC (rev 104305)
+++ trunk/LayoutTests/fullscreen/video-controls-drag.html 2012-01-06 19:38:46 UTC (rev 104306)
@@ -1,6 +1,6 @@
<body>
<p>This tests that the video element's controls are draggable in full screen. Press any key to continue.</p>
- <video id="video" width="300" controls></video>
+ <video id="video" width="300"></video>
<script src=""
<script src=""
<script>
Modified: trunk/Source/WebCore/ChangeLog (104305 => 104306)
--- trunk/Source/WebCore/ChangeLog 2012-01-06 19:30:16 UTC (rev 104305)
+++ trunk/Source/WebCore/ChangeLog 2012-01-06 19:38:46 UTC (rev 104306)
@@ -1,3 +1,18 @@
+2012-01-06 Jer Noble <[email protected]>
+
+ Fullscreen video controller can't be dragged the first time I enter fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=75709
+
+ Reviewed by Eric Carlson.
+
+ No new tests; updated video-controls-drag.html.
+
+ When the media controls are created, check to see if we are full screen, and pass
+ that information to the newly created controls.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::createMediaControls):
+
2012-01-05 Jer Noble <[email protected]>
Media Element: scrubbing in full-screen mode breaks playback.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (104305 => 104306)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-01-06 19:30:16 UTC (rev 104305)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-01-06 19:38:46 UTC (rev 104306)
@@ -3484,6 +3484,8 @@
controls->setMediaController(m_mediaController ? m_mediaController.get() : static_cast<MediaControllerInterface*>(this));
controls->reset();
+ if (isFullscreen())
+ controls->enteredFullscreen();
ensureShadowRoot()->appendChild(controls, ec);
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
