Title: [261816] trunk/Tools
- Revision
- 261816
- Author
- [email protected]
- Date
- 2020-05-18 09:41:31 -0700 (Mon, 18 May 2020)
Log Message
[iPad Simulator] TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia is timing out
https://bugs.webkit.org/show_bug.cgi?id=211792
Reviewed by Daniel Bates.
Fix deadlocks in two API tests (only reproducible on iPad simulators).
* TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (261815 => 261816)
--- trunk/Tools/ChangeLog 2020-05-18 16:23:30 UTC (rev 261815)
+++ trunk/Tools/ChangeLog 2020-05-18 16:41:31 UTC (rev 261816)
@@ -1,3 +1,17 @@
+2020-05-18 Peng Liu <[email protected]>
+
+ [iPad Simulator] TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=211792
+
+ Reviewed by Daniel Bates.
+
+ Fix deadlocks in two API tests (only reproducible on iPad simulators).
+
+ * TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm:
+ (TestWebKitAPI::TEST):
+ * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
+ (TestWebKitAPI::TEST):
+
2020-05-18 Wenson Hsieh <[email protected]>
Single selection <select> with <optgroups> shows multiple selected options
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm (261815 => 261816)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm 2020-05-18 16:23:30 UTC (rev 261815)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm 2020-05-18 16:41:31 UTC (rev 261816)
@@ -101,7 +101,7 @@
Util::run(&didFinishLoad);
Util::run(&gotMainFrame);
- callOnMainThreadAndWait([&] () mutable {
+ callOnMainThread([&] () mutable {
[mainFrame setTimeoutsPaused:YES];
DOMHTMLMediaElement* video1 = (DOMHTMLMediaElement*)[[mainFrame DOMDocument] getElementById:@"video1"];
[video1 addEventListener:@"canplaythrough" listener:uiDelegate.get() useCapture:NO];
@@ -120,7 +120,7 @@
// Wait until both video elements are ready to play.
Util::run(&readyToTest);
- callOnMainThreadAndWait([&] () mutable {
+ callOnMainThread([&] () mutable {
DOMHTMLMediaElement* video1 = (DOMHTMLMediaElement*)[[mainFrame DOMDocument] getElementById:@"video1"];
DOMHTMLMediaElement* video2 = (DOMHTMLMediaElement*)[[mainFrame DOMDocument] getElementById:@"video2"];
[video1 play];
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm (261815 => 261816)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm 2020-05-18 16:23:30 UTC (rev 261815)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm 2020-05-18 16:41:31 UTC (rev 261816)
@@ -93,7 +93,7 @@
Util::run(&didFinishLoad);
Util::run(&gotMainFrame);
- callOnMainThreadAndWait([&] () mutable {
+ callOnMainThread([&] () mutable {
[mainFrame setTimeoutsPaused:YES];
DOMHTMLMediaElement* video = (DOMHTMLMediaElement*)[[mainFrame DOMDocument] querySelector:@"video"];
@@ -109,7 +109,7 @@
Util::run(&readyToTest);
- callOnMainThreadAndWait([&] () mutable {
+ callOnMainThread([&] () mutable {
DOMHTMLMediaElement* video = (DOMHTMLMediaElement*)[[mainFrame DOMDocument] querySelector:@"video"];
ASSERT_TRUE([video isKindOfClass:[DOMHTMLMediaElement class]]);
@@ -118,7 +118,7 @@
Util::run(&didReceivePlaying);
- callOnMainThreadAndWait([&] () mutable {
+ callOnMainThread([&] () mutable {
DOMHTMLMediaElement* video = (DOMHTMLMediaElement*)[[mainFrame DOMDocument] querySelector:@"video"];
ASSERT_TRUE([video isKindOfClass:[DOMHTMLMediaElement class]]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
