Title: [261927] trunk/Source/WebCore
- Revision
- 261927
- Author
- grao...@webkit.org
- Date
- 2020-05-20 09:29:50 -0700 (Wed, 20 May 2020)
Log Message
[Web Animations] Animation engine should not wake up every tick for steps timing functions
https://bugs.webkit.org/show_bug.cgi?id=212103
<rdar://problem/62737868>
Unreviewed. Clean up some stray FIXMEs mistakenly commited in the previous commit.
* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (261926 => 261927)
--- trunk/Source/WebCore/ChangeLog 2020-05-20 16:26:16 UTC (rev 261926)
+++ trunk/Source/WebCore/ChangeLog 2020-05-20 16:29:50 UTC (rev 261927)
@@ -4,6 +4,19 @@
https://bugs.webkit.org/show_bug.cgi?id=212103
<rdar://problem/62737868>
+ Unreviewed. Clean up some stray FIXMEs mistakenly commited in the previous commit.
+
+ * animation/AnimationTimeline.cpp:
+ (WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
+ * style/StyleTreeResolver.cpp:
+ (WebCore::Style::TreeResolver::createAnimatedElementUpdate):
+
+2020-05-20 Antoine Quint <grao...@apple.com>
+
+ [Web Animations] Animation engine should not wake up every tick for steps timing functions
+ https://bugs.webkit.org/show_bug.cgi?id=212103
+ <rdar://problem/62737868>
+
Reviewed by Simon Fraser.
Tests: webanimations/scheduling-of-animation-with-steps-timing-function-on-effect.html
Modified: trunk/Source/WebCore/animation/AnimationTimeline.cpp (261926 => 261927)
--- trunk/Source/WebCore/animation/AnimationTimeline.cpp 2020-05-20 16:26:16 UTC (rev 261926)
+++ trunk/Source/WebCore/animation/AnimationTimeline.cpp 2020-05-20 16:29:50 UTC (rev 261927)
@@ -399,9 +399,6 @@
// If we already have a keyframe effect targeting this property, we should use its unanimated style to determine what the potential
// start value of the transition shoud be to make sure that we don't account for animated values that would have been blended onto
// the style applied during the last style resolution.
-
- // FIXME: NO. We should be applying animations with the current time.
-
if (auto* unanimatedStyle = keyframeEffect->unanimatedStyle())
return RenderStyle::clone(*unanimatedStyle);
Modified: trunk/Source/WebCore/style/StyleTreeResolver.cpp (261926 => 261927)
--- trunk/Source/WebCore/style/StyleTreeResolver.cpp 2020-05-20 16:26:16 UTC (rev 261926)
+++ trunk/Source/WebCore/style/StyleTreeResolver.cpp 2020-05-20 16:29:50 UTC (rev 261927)
@@ -317,7 +317,6 @@
if (oldStyle && (oldStyle->hasTransitions() || newStyle->hasTransitions()))
m_document.timeline().updateCSSTransitionsForElement(element, *oldStyle, *newStyle);
- // FIXME: Maybe need to do this first such that CSS Transitions are aware of newly created or canceled animations
if ((oldStyle && oldStyle->hasAnimations()) || newStyle->hasAnimations())
m_document.timeline().updateCSSAnimationsForElement(element, oldStyle, *newStyle);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
