Title: [262103] trunk/Source/WebCore
Revision
262103
Author
[email protected]
Date
2020-05-23 13:13:57 -0700 (Sat, 23 May 2020)

Log Message

ASSERTION FAILED: (!s_current || &m_view != &s_current->m_view) in RenderTreeBuilder::RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=212163

Unreviewed. Improve readability. Replace comments with curly brackets for scoping.


* dom/Document.cpp:
(WebCore::Document::updateRenderTree):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (262102 => 262103)


--- trunk/Source/WebCore/ChangeLog	2020-05-23 19:47:51 UTC (rev 262102)
+++ trunk/Source/WebCore/ChangeLog	2020-05-23 20:13:57 UTC (rev 262103)
@@ -1,3 +1,13 @@
+2020-05-23  Jack Lee  <[email protected]>
+
+        ASSERTION FAILED: (!s_current || &m_view != &s_current->m_view) in RenderTreeBuilder::RenderTreeBuilder
+        https://bugs.webkit.org/show_bug.cgi?id=212163
+
+        Unreviewed. Improve readability. Replace comments with curly brackets for scoping.
+
+        * dom/Document.cpp:
+        (WebCore::Document::updateRenderTree):
+
 2020-05-23  Zalan Bujtas  <[email protected]>
 
         [LFC][TFC] Maximum constraint of a cell should never be smaller than the minimum width

Modified: trunk/Source/WebCore/dom/Document.cpp (262102 => 262103)


--- trunk/Source/WebCore/dom/Document.cpp	2020-05-23 19:47:51 UTC (rev 262102)
+++ trunk/Source/WebCore/dom/Document.cpp	2020-05-23 20:13:57 UTC (rev 262103)
@@ -1924,13 +1924,14 @@
 {
     ASSERT(!inRenderTreeUpdate());
 
-    // NOTE: Preserve the order of definitions below so the destructors are called in proper sequence.
     Style::PostResolutionCallbackDisabler callbackDisabler(*this);
-    SetForScope<bool> inRenderTreeUpdate(m_inRenderTreeUpdate, true);
-    RenderTreeUpdater updater(*this, callbackDisabler);
-    // End of ordered definitions
-
-    updater.commit(WTFMove(styleUpdate));
+    {
+        SetForScope<bool> inRenderTreeUpdate(m_inRenderTreeUpdate, true);
+        {
+            RenderTreeUpdater updater(*this, callbackDisabler);
+            updater.commit(WTFMove(styleUpdate));
+        }
+    }
 }
 
 void Document::resolveStyle(ResolveStyleType type)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to