Title: [263225] trunk/Source/WebInspectorUI
Revision
263225
Author
drou...@apple.com
Date
2020-06-18 13:12:48 -0700 (Thu, 18 Jun 2020)

Log Message

Web Inspector: Console: add comments for localized strings in execution context picker
https://bugs.webkit.org/show_bug.cgi?id=213280

Reviewed by Joseph Pecoraro.

* UserInterface/Views/QuickConsole.js:
(WI.QuickConsole.prototype._populateActiveExecutionContextNavigationItemContextMenu):

* Localizations/en.lproj/localizedStrings.js:

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (263224 => 263225)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-06-18 20:07:22 UTC (rev 263224)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-06-18 20:12:48 UTC (rev 263225)
@@ -1,3 +1,15 @@
+2020-06-18  Devin Rousso  <drou...@apple.com>
+
+        Web Inspector: Console: add comments for localized strings in execution context picker
+        https://bugs.webkit.org/show_bug.cgi?id=213280
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/QuickConsole.js:
+        (WI.QuickConsole.prototype._populateActiveExecutionContextNavigationItemContextMenu):
+
+        * Localizations/en.lproj/localizedStrings.js:
+
 2020-06-16  Devin Rousso  <drou...@apple.com>
 
         Web Inspector: Sources: objects in Scope Chain panel flicker when resizing details sidebar

Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (263224 => 263225)


--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2020-06-18 20:07:22 UTC (rev 263224)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2020-06-18 20:12:48 UTC (rev 263225)
@@ -605,6 +605,8 @@
 localizedStrings["Frame URL"] = "Frame URL";
 localizedStrings["Frames"] = "Frames";
 localizedStrings["Frames %d \u2013 %d"] = "Frames %d \u2013 %d";
+/* Title for list of HTML subframe _javascript_ execution contexts */
+localizedStrings["Frames @ Execution Context Picker"] = "Frames";
 localizedStrings["Full Garbage Collection"] = "Full Garbage Collection";
 localizedStrings["Full URL"] = "Full URL";
 localizedStrings["Full-Screen"] = "Full-Screen";
@@ -1441,7 +1443,8 @@
 localizedStrings["Worker Thread"] = "Worker Thread";
 localizedStrings["Worker Threads"] = "Worker Threads";
 localizedStrings["Worker: %s"] = "Worker: %s";
-localizedStrings["Workers"] = "Workers";
+/* Title for list of _javascript_ web worker execution contexts */
+localizedStrings["Workers @ Execution Context Picker"] = "Workers";
 localizedStrings["Wrap lines to editor width"] = "Wrap lines to editor width";
 localizedStrings["XBM"] = "XBM";
 localizedStrings["XHR"] = "XHR";

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js (263224 => 263225)


--- trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js	2020-06-18 20:07:22 UTC (rev 263224)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js	2020-06-18 20:12:48 UTC (rev 263225)
@@ -282,7 +282,7 @@
 
         let otherFrames = WI.networkManager.frames.filter((frame) => frame !== mainFrame && frame.executionContextList.pageExecutionContext);
         if (otherFrames.length) {
-            contextMenu.appendHeader(WI.UIString("Frames"));
+            contextMenu.appendHeader(WI.UIString("Frames", "Frames @ Execution Context Picker", "Title for list of HTML subframe _javascript_ execution contexts"));
 
             for (let frame of otherFrames)
                 addExecutionContextsForFrame(frame);
@@ -290,7 +290,7 @@
 
         let workerTargets = WI.targetManager.workerTargets;
         if (workerTargets.length) {
-            contextMenu.appendHeader(WI.UIString("Workers"));
+            contextMenu.appendHeader(WI.UIString("Workers", "Workers @ Execution Context Picker", "Title for list of _javascript_ web worker execution contexts"));
 
             for (let target of workerTargets)
                 addExecutionContext(target.executionContext);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to