- Revision
- 263265
- Author
- svil...@igalia.com
- Date
- 2020-06-19 07:35:36 -0700 (Fri, 19 Jun 2020)
Log Message
REGRESSION(r262254?): [WPE] imported/w3c/web-platform-tests/webxr/idlharness.https.window.html is failing
https://bugs.webkit.org/show_bug.cgi?id=212897
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
* web-platform-tests/webxr/idlharness.https.window-expected.txt: Updated expectations.
Source/WebCore:
WPT tests were updated in r262254 and they already include the latest changes in the specs. Among others the
XR interface was renamed to XRSystem. We were already using that name in the C++ code but not in the JS interface.
The WPT update brings in another set of changes like the new XRLayer which is already not supported (I am
adding it soon in another patch). Last but not least, the new tests include checks for the XRPermissionStatus interface
which is not going to be implemented soon as it requires the Permission API which is not supported in WebKit yet. All in
all, this patch renames XR to XRSystem and marks as failing the XRLayer (temporarily) and XRPermissionStatus checks.
No new tests as there is no change in functionality.
* Modules/webxr/WebXRSystem.idl: Rename XR to XRSystem.
* bindings/js/WebCoreBuiltinNames.h: Ditto.
LayoutTests:
* platform/wpe/TestExpectations: Re-enable the idlharness.https.window.html test.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (263264 => 263265)
--- trunk/LayoutTests/ChangeLog 2020-06-19 13:52:59 UTC (rev 263264)
+++ trunk/LayoutTests/ChangeLog 2020-06-19 14:35:36 UTC (rev 263265)
@@ -1,3 +1,12 @@
+2020-06-10 Sergio Villar Senin <svil...@igalia.com>
+
+ REGRESSION(r262254?): [WPE] imported/w3c/web-platform-tests/webxr/idlharness.https.window.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=212897
+
+ Reviewed by Youenn Fablet.
+
+ * platform/wpe/TestExpectations: Re-enable the idlharness.https.window.html test.
+
2020-06-18 Lauro Moura <lmo...@igalia.com>
[GTK] Garden some flaky crashes and start expect reorg
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (263264 => 263265)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-06-19 13:52:59 UTC (rev 263264)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-06-19 14:35:36 UTC (rev 263265)
@@ -1,3 +1,12 @@
+2020-06-10 Sergio Villar Senin <svil...@igalia.com>
+
+ REGRESSION(r262254?): [WPE] imported/w3c/web-platform-tests/webxr/idlharness.https.window.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=212897
+
+ Reviewed by Youenn Fablet.
+
+ * web-platform-tests/webxr/idlharness.https.window-expected.txt: Updated expectations.
+
2020-06-17 Clark Wang <clark_w...@apple.com>
Added missing orientation attributes to PannerNode
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/idlharness.https.window-expected.txt (263264 => 263265)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/idlharness.https.window-expected.txt 2020-06-19 13:52:59 UTC (rev 263264)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/idlharness.https.window-expected.txt 2020-06-19 14:35:36 UTC (rev 263265)
@@ -18,22 +18,15 @@
PASS Navigator includes NavigatorCookies: member names are unique
PASS Navigator includes NavigatorPlugins: member names are unique
PASS Navigator includes NavigatorConcurrentHardware: member names are unique
-PASS XR interface: existence and properties of interface object
-PASS XR interface object length
-PASS XR interface object name
-PASS XR interface: existence and properties of interface prototype object
-PASS XR interface: existence and properties of interface prototype object's "constructor" property
-PASS XR interface: existence and properties of interface prototype object's @@unscopables property
-PASS XR interface: operation isSessionSupported(XRSessionMode)
-PASS XR interface: operation requestSession(XRSessionMode, XRSessionInit)
-PASS XR interface: attribute ondevicechange
-PASS XR must be primary interface of navigator.xr
-PASS Stringification of navigator.xr
-PASS XR interface: navigator.xr must inherit property "isSessionSupported(XRSessionMode)" with the proper type
-PASS XR interface: calling isSessionSupported(XRSessionMode) on navigator.xr with too few arguments must throw TypeError
-PASS XR interface: navigator.xr must inherit property "requestSession(XRSessionMode, XRSessionInit)" with the proper type
-PASS XR interface: calling requestSession(XRSessionMode, XRSessionInit) on navigator.xr with too few arguments must throw TypeError
-PASS XR interface: navigator.xr must inherit property "ondevicechange" with the proper type
+PASS XRSystem interface: existence and properties of interface object
+PASS XRSystem interface object length
+PASS XRSystem interface object name
+PASS XRSystem interface: existence and properties of interface prototype object
+PASS XRSystem interface: existence and properties of interface prototype object's "constructor" property
+PASS XRSystem interface: existence and properties of interface prototype object's @@unscopables property
+PASS XRSystem interface: operation isSessionSupported(XRSessionMode)
+PASS XRSystem interface: operation requestSession(XRSessionMode, optional XRSessionInit)
+PASS XRSystem interface: attribute ondevicechange
PASS XRSession interface: existence and properties of interface object
PASS XRSession interface object length
PASS XRSession interface object name
@@ -43,7 +36,7 @@
PASS XRSession interface: attribute visibilityState
PASS XRSession interface: attribute renderState
PASS XRSession interface: attribute inputSources
-PASS XRSession interface: operation updateRenderState(XRRenderStateInit)
+PASS XRSession interface: operation updateRenderState(optional XRRenderStateInit)
PASS XRSession interface: operation requestReferenceSpace(XRReferenceSpaceType)
PASS XRSession interface: operation requestAnimationFrame(XRFrameRequestCallback)
PASS XRSession interface: operation cancelAnimationFrame(long)
@@ -160,10 +153,16 @@
PASS XRInputSourceArray interface: existence and properties of interface prototype object's @@unscopables property
PASS XRInputSourceArray interface: iterable<XRInputSource>
PASS XRInputSourceArray interface: attribute length
-PASS XRWebGLLayer interface: existence and properties of interface object
+FAIL XRLayer interface: existence and properties of interface object assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
+FAIL XRLayer interface object length assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
+FAIL XRLayer interface object name assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
+FAIL XRLayer interface: existence and properties of interface prototype object assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
+FAIL XRLayer interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
+FAIL XRLayer interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
+FAIL XRWebGLLayer interface: existence and properties of interface object assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
PASS XRWebGLLayer interface object length
PASS XRWebGLLayer interface object name
-PASS XRWebGLLayer interface: existence and properties of interface prototype object
+FAIL XRWebGLLayer interface: existence and properties of interface prototype object assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
PASS XRWebGLLayer interface: existence and properties of interface prototype object's "constructor" property
PASS XRWebGLLayer interface: existence and properties of interface prototype object's @@unscopables property
PASS XRWebGLLayer interface: attribute antialias
@@ -205,6 +204,13 @@
PASS XRReferenceSpaceEvent interface: existence and properties of interface prototype object's @@unscopables property
PASS XRReferenceSpaceEvent interface: attribute referenceSpace
PASS XRReferenceSpaceEvent interface: attribute transform
+FAIL XRPermissionStatus interface: existence and properties of interface object assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
+FAIL XRPermissionStatus interface object length assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
+FAIL XRPermissionStatus interface object name assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
+FAIL XRPermissionStatus interface: existence and properties of interface prototype object assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
+FAIL XRPermissionStatus interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
+FAIL XRPermissionStatus interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
+FAIL XRPermissionStatus interface: attribute granted assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
PASS Navigator interface: attribute xr
PASS Navigator interface: navigator must inherit property "xr" with the proper type
Modified: trunk/LayoutTests/platform/wpe/TestExpectations (263264 => 263265)
--- trunk/LayoutTests/platform/wpe/TestExpectations 2020-06-19 13:52:59 UTC (rev 263264)
+++ trunk/LayoutTests/platform/wpe/TestExpectations 2020-06-19 14:35:36 UTC (rev 263265)
@@ -921,7 +921,7 @@
imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-013.html [ Pass ]
# WebXR
-webkit.org/b/212897 imported/w3c/web-platform-tests/webxr/idlharness.https.window.html [ Failure ]
+webkit.org/b/212897 imported/w3c/web-platform-tests/webxr/idlharness.https.window.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_inline.https.html [ Pass ]
Modified: trunk/Source/WebCore/ChangeLog (263264 => 263265)
--- trunk/Source/WebCore/ChangeLog 2020-06-19 13:52:59 UTC (rev 263264)
+++ trunk/Source/WebCore/ChangeLog 2020-06-19 14:35:36 UTC (rev 263265)
@@ -1,3 +1,22 @@
+2020-06-10 Sergio Villar Senin <svil...@igalia.com>
+
+ REGRESSION(r262254?): [WPE] imported/w3c/web-platform-tests/webxr/idlharness.https.window.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=212897
+
+ Reviewed by Youenn Fablet.
+
+ WPT tests were updated in r262254 and they already include the latest changes in the specs. Among others the
+ XR interface was renamed to XRSystem. We were already using that name in the C++ code but not in the JS interface.
+ The WPT update brings in another set of changes like the new XRLayer which is already not supported (I am
+ adding it soon in another patch). Last but not least, the new tests include checks for the XRPermissionStatus interface
+ which is not going to be implemented soon as it requires the Permission API which is not supported in WebKit yet. All in
+ all, this patch renames XR to XRSystem and marks as failing the XRLayer (temporarily) and XRPermissionStatus checks.
+
+ No new tests as there is no change in functionality.
+
+ * Modules/webxr/WebXRSystem.idl: Rename XR to XRSystem.
+ * bindings/js/WebCoreBuiltinNames.h: Ditto.
+
2020-06-19 Zalan Bujtas <za...@apple.com>
[LFC][BFC] Min/max-width should always be resolved against the containing block width
Modified: trunk/Source/WebCore/Modules/webxr/WebXRSystem.idl (263264 => 263265)
--- trunk/Source/WebCore/Modules/webxr/WebXRSystem.idl 2020-06-19 13:52:59 UTC (rev 263264)
+++ trunk/Source/WebCore/Modules/webxr/WebXRSystem.idl 2020-06-19 14:35:36 UTC (rev 263265)
@@ -29,7 +29,7 @@
ActiveDOMObject,
SecureContext,
Exposed=Window,
- InterfaceName=XR
+ InterfaceName=XRSystem
] interface WebXRSystem : EventTarget {
// Methods
Promise<void> isSessionSupported(XRSessionMode mode);
Modified: trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h (263264 => 263265)
--- trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2020-06-19 13:52:59 UTC (rev 263264)
+++ trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2020-06-19 14:35:36 UTC (rev 263265)
@@ -245,7 +245,6 @@
macro(WorkletGlobalScope) \
macro(WritableStream) \
macro(XMLHttpRequest) \
- macro(XR) \
macro(XRBoundedReferenceSpace) \
macro(XRFrame) \
macro(XRInputSource) \
@@ -260,6 +259,7 @@
macro(XRSession) \
macro(XRSessionEvent) \
macro(XRSpace) \
+ macro(XRSystem) \
macro(XRTest) \
macro(XRView) \
macro(XRViewerPose) \
