Title: [264030] trunk/Source/WebCore
- Revision
- 264030
- Author
- [email protected]
- Date
- 2020-07-07 11:03:15 -0700 (Tue, 07 Jul 2020)
Log Message
Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=214032
Reviewed by Eric Carlson.
VideoFullscreenManagerProxy::didCleanupFullscreen() may destroy an instance of VideoFullscreenInterfaceAVKit.
So we should not access member variables of VideoFullscreenInterfaceAVKit after calling didCleanupFullscreen()
in VideoFullscreenInterfaceAVKit::cleanupFullscreen().
Fix a flaky test crash: media/video-autoplay.html
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::cleanupFullscreen):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264029 => 264030)
--- trunk/Source/WebCore/ChangeLog 2020-07-07 17:40:53 UTC (rev 264029)
+++ trunk/Source/WebCore/ChangeLog 2020-07-07 18:03:15 UTC (rev 264030)
@@ -1,3 +1,19 @@
+2020-07-07 Peng Liu <[email protected]>
+
+ Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen()
+ https://bugs.webkit.org/show_bug.cgi?id=214032
+
+ Reviewed by Eric Carlson.
+
+ VideoFullscreenManagerProxy::didCleanupFullscreen() may destroy an instance of VideoFullscreenInterfaceAVKit.
+ So we should not access member variables of VideoFullscreenInterfaceAVKit after calling didCleanupFullscreen()
+ in VideoFullscreenInterfaceAVKit::cleanupFullscreen().
+
+ Fix a flaky test crash: media/video-autoplay.html
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+ (VideoFullscreenInterfaceAVKit::cleanupFullscreen):
+
2020-07-07 Tim Horton <[email protected]>
<attachment> layout does not scale with Dynamic Type size changes
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (264029 => 264030)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2020-07-07 17:40:53 UTC (rev 264029)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2020-07-07 18:03:15 UTC (rev 264030)
@@ -982,12 +982,12 @@
m_videoView = nil;
m_parentView = nil;
m_parentWindow = nil;
-
- if (m_fullscreenChangeObserver)
- m_fullscreenChangeObserver->didCleanupFullscreen();
[playerController() setHasEnabledVideo:false];
[playerController() setHasVideo:false];
+
+ if (m_fullscreenChangeObserver)
+ m_fullscreenChangeObserver->didCleanupFullscreen();
}
void VideoFullscreenInterfaceAVKit::invalidate()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
