Title: [264065] trunk/Tools
- Revision
- 264065
- Author
- [email protected]
- Date
- 2020-07-08 01:42:50 -0700 (Wed, 08 Jul 2020)
Log Message
[webkitpy] run-minibrowser doesn't default to mac and stdout/stderr are not displayed
https://bugs.webkit.org/show_bug.cgi?id=214072
Patch by Philippe Normand <[email protected]> on 2020-07-08
Reviewed by Adrian Perez de Castro.
* Scripts/webkitpy/minibrowser/run_webkit_app.py:
(main): Default to mac platform, like in old-run-minibrowser.
* Scripts/webkitpy/port/base.py:
(Port.run_minibrowser): Display MiniBrowser stdout and stderr on the terminal output.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (264064 => 264065)
--- trunk/Tools/ChangeLog 2020-07-08 08:39:59 UTC (rev 264064)
+++ trunk/Tools/ChangeLog 2020-07-08 08:42:50 UTC (rev 264065)
@@ -1,3 +1,15 @@
+2020-07-08 Philippe Normand <[email protected]>
+
+ [webkitpy] run-minibrowser doesn't default to mac and stdout/stderr are not displayed
+ https://bugs.webkit.org/show_bug.cgi?id=214072
+
+ Reviewed by Adrian Perez de Castro.
+
+ * Scripts/webkitpy/minibrowser/run_webkit_app.py:
+ (main): Default to mac platform, like in old-run-minibrowser.
+ * Scripts/webkitpy/port/base.py:
+ (Port.run_minibrowser): Display MiniBrowser stdout and stderr on the terminal output.
+
2020-07-08 Diego Pino Garcia <[email protected]>
[Flatpak] Avoid error message 'error: org.webkit.Sdk/*unspecified*/*unspecified*' not installed
Modified: trunk/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py (264064 => 264065)
--- trunk/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py 2020-07-08 08:39:59 UTC (rev 264064)
+++ trunk/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py 2020-07-08 08:42:50 UTC (rev 264065)
@@ -49,10 +49,8 @@
if not options.configuration:
options.configuration = "Release"
- if set(args).issubset(["-h", "--help"]) and not options.platform:
- option_parser.print_help()
- print("\nTo see the available options on a specific platform, supply it on the command-line, for example --gtk --help")
- return 0
+ if not options.platform:
+ options.platform = "mac"
try:
port = factory.PortFactory(Host()).get(options.platform, options=options)
Modified: trunk/Tools/Scripts/webkitpy/port/base.py (264064 => 264065)
--- trunk/Tools/Scripts/webkitpy/port/base.py 2020-07-08 08:39:59 UTC (rev 264064)
+++ trunk/Tools/Scripts/webkitpy/port/base.py 2020-07-08 08:42:50 UTC (rev 264065)
@@ -1369,7 +1369,8 @@
def run_minibrowser(self, args):
# FIXME: Migrate to webkitpy based run-minibrowser. https://bugs.webkit.org/show_bug.cgi?id=213464
- return self._run_script("old-run-minibrowser", args=args)
+ miniBrowser = self.path_to_script("old-run-minibrowser")
+ return self._executive.run_command([miniBrowser] + args, stdout=None, cwd=self.webkit_base(), return_stderr=False, decode_output=False)
@memoized
def _path_to_image_diff(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
