Title: [264094] trunk/Tools
- Revision
- 264094
- Author
- [email protected]
- Date
- 2020-07-08 04:02:30 -0700 (Wed, 08 Jul 2020)
Log Message
[GTK][WPE] install-dependencies should install the gstreamer plugins
https://bugs.webkit.org/show_bug.cgi?id=214045
Reviewed by Adrian Perez de Castro.
When building webkit against system libraries (without flatpak/jhbuild)
its needed to have installed the webkit plugins to play media files.
The install-dependencies script should install them.
gstreamer-plugins-ugly its likely not needed for the majority of the cases,
but it can be required by some ugly media files that require an ugly decoder.
Since we are installing it on the flatpak, let's add it here as well.
* gtk/install-dependencies:
* wpe/install-dependencies:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (264093 => 264094)
--- trunk/Tools/ChangeLog 2020-07-08 10:53:26 UTC (rev 264093)
+++ trunk/Tools/ChangeLog 2020-07-08 11:02:30 UTC (rev 264094)
@@ -1,3 +1,21 @@
+2020-07-08 Carlos Alberto Lopez Perez <[email protected]>
+
+ [GTK][WPE] install-dependencies should install the gstreamer plugins
+ https://bugs.webkit.org/show_bug.cgi?id=214045
+
+ Reviewed by Adrian Perez de Castro.
+
+ When building webkit against system libraries (without flatpak/jhbuild)
+ its needed to have installed the webkit plugins to play media files.
+ The install-dependencies script should install them.
+
+ gstreamer-plugins-ugly its likely not needed for the majority of the cases,
+ but it can be required by some ugly media files that require an ugly decoder.
+ Since we are installing it on the flatpak, let's add it here as well.
+
+ * gtk/install-dependencies:
+ * wpe/install-dependencies:
+
2020-07-08 Philippe Normand <[email protected]>
[webkitpy] run-minibrowser doesn't handle unicode urls
Modified: trunk/Tools/gtk/install-dependencies (264093 => 264094)
--- trunk/Tools/gtk/install-dependencies 2020-07-08 10:53:26 UTC (rev 264093)
+++ trunk/Tools/gtk/install-dependencies 2020-07-08 11:02:30 UTC (rev 264094)
@@ -249,6 +249,16 @@
python3-secretstorage \
subversion"
+ # These are GStreamer plugins needed to play different media files.
+ packages="$packages \
+ gstreamer1.0-gl \
+ gstreamer1.0-libav \
+ gstreamer1.0-plugins-bad \
+ gstreamer1.0-plugins-base \
+ gstreamer1.0-plugins-good \
+ gstreamer1.0-plugins-ugly \
+ gstreamer1.0-pulseaudio"
+
apt-get install $packages
# Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path.
@@ -280,7 +290,6 @@
grep \
groff \
gstreamer \
- gst-plugins-bad \
gst-plugins-base-libs \
gzip \
hyphen \
@@ -424,6 +433,14 @@
packages="$packages \
python-secretstorage \
svn"
+
+ # These are GStreamer plugins needed to play different media files.
+ packages="$packages \
+ gst-plugins-bad \
+ gst-plugins-base \
+ gst-plugins-good \
+ gst-plugins-ugly"
+
pacman -S --needed $packages
cat <<-EOF
@@ -599,6 +616,15 @@
python3-secretstorage \
subversion"
+ # These are GStreamer plugins needed to play different media files.
+ packages="$packages \
+ gstreamer1-plugins-bad-free \
+ gstreamer1-plugins-bad-free-extras \
+ gstreamer1-plugins-base \
+ gstreamer1-plugins-good \
+ gstreamer1-plugins-good-extras \
+ gstreamer1-plugins-ugly-free"
+
dnf install $packages
}
Modified: trunk/Tools/wpe/install-dependencies (264093 => 264094)
--- trunk/Tools/wpe/install-dependencies 2020-07-08 10:53:26 UTC (rev 264093)
+++ trunk/Tools/wpe/install-dependencies 2020-07-08 11:02:30 UTC (rev 264094)
@@ -152,6 +152,16 @@
python3-secretstorage \
subversion"
+ # These are GStreamer plugins needed to play different media files.
+ packages="$packages \
+ gstreamer1.0-gl \
+ gstreamer1.0-libav \
+ gstreamer1.0-plugins-bad \
+ gstreamer1.0-plugins-base \
+ gstreamer1.0-plugins-good \
+ gstreamer1.0-plugins-ugly \
+ gstreamer1.0-pulseaudio"
+
apt-get install $packages
# Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path.
@@ -181,7 +191,6 @@
grep \
groff \
gstreamer \
- gst-plugins-bad \
gst-plugins-base-libs \
gzip \
icu \
@@ -266,6 +275,14 @@
packages="$packages \
python-secretstorage \
svn"
+
+ # These are GStreamer plugins needed to play different media files.
+ packages="$packages \
+ gst-plugins-bad \
+ gst-plugins-base \
+ gst-plugins-good \
+ gst-plugins-ugly"
+
pacman -S --needed $packages
cat <<-EOF
@@ -390,6 +407,15 @@
python3-secretstorage \
subversion"
+ # These are GStreamer plugins needed to play different media files.
+ packages="$packages \
+ gstreamer1-plugins-bad-free \
+ gstreamer1-plugins-bad-free-extras \
+ gstreamer1-plugins-base \
+ gstreamer1-plugins-good \
+ gstreamer1-plugins-good-extras \
+ gstreamer1-plugins-ugly-free"
+
dnf install $packages
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
