Title: [264329] trunk/Source/WebCore
- Revision
- 264329
- Author
- [email protected]
- Date
- 2020-07-13 20:44:08 -0700 (Mon, 13 Jul 2020)
Log Message
Keyboard remains on full screen video view after back from PiP
https://bugs.webkit.org/show_bug.cgi?id=214287
Reviewed by Daniel Bates.
Make the window for video fullscreen and picture-in-picture support the key window
after the video returns to fullscreen from the picture-in-picture mode. Otherwise,
the WebAVPlayerViewController cannot become the first responder.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::didStopPictureInPicture):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264328 => 264329)
--- trunk/Source/WebCore/ChangeLog 2020-07-14 02:53:45 UTC (rev 264328)
+++ trunk/Source/WebCore/ChangeLog 2020-07-14 03:44:08 UTC (rev 264329)
@@ -1,3 +1,17 @@
+2020-07-13 Peng Liu <[email protected]>
+
+ Keyboard remains on full screen video view after back from PiP
+ https://bugs.webkit.org/show_bug.cgi?id=214287
+
+ Reviewed by Daniel Bates.
+
+ Make the window for video fullscreen and picture-in-picture support the key window
+ after the video returns to fullscreen from the picture-in-picture mode. Otherwise,
+ the WebAVPlayerViewController cannot become the first responder.
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+ (VideoFullscreenInterfaceAVKit::didStopPictureInPicture):
+
2020-07-13 Zalan Bujtas <[email protected]>
[RenderTreeNeedsLayoutChecker] imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/video-controls-vertical-writing-mode.html asserts
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (264328 => 264329)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2020-07-14 02:53:45 UTC (rev 264328)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2020-07-14 03:44:08 UTC (rev 264329)
@@ -1145,6 +1145,7 @@
if (m_currentMode.hasFullscreen() || m_restoringFullscreenForPictureInPictureStop) {
clearMode(HTMLMediaElementEnums::VideoFullscreenModePictureInPicture);
+ [m_window makeKeyWindow];
[m_playerViewController setShowsPlaybackControls:YES];
if (m_exitFullscreenNeedsExitPictureInPicture)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
