Title: [264496] trunk/Source/ThirdParty/libwebrtc
Revision
264496
Author
[email protected]
Date
2020-07-16 20:36:07 -0700 (Thu, 16 Jul 2020)

Log Message

Unreviewed build fix after r264492; previously dead code in RTCNativeI420Buffer.mm was
revivified after a project file fix which stopped setting NDEBUG for debug builds in
libwebrc. Delete this undead code, which would have always caused build errors if it was
ever compiled.

* Source/webrtc/sdk/objc/api/video_frame_buffer/RTCNativeI420Buffer.mm:
(-[RTCI420Buffer debugQuickLookObject]): Deleted.

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (264495 => 264496)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2020-07-17 03:36:05 UTC (rev 264495)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2020-07-17 03:36:07 UTC (rev 264496)
@@ -1,5 +1,15 @@
 2020-07-16  Jer Noble  <[email protected]>
 
+        Unreviewed build fix after r264492; previously dead code in RTCNativeI420Buffer.mm was
+        revivified after a project file fix which stopped setting NDEBUG for debug builds in
+        libwebrc. Delete this undead code, which would have always caused build errors if it was
+        ever compiled.
+
+        * Source/webrtc/sdk/objc/api/video_frame_buffer/RTCNativeI420Buffer.mm:
+        (-[RTCI420Buffer debugQuickLookObject]): Deleted.
+
+2020-07-16  Jer Noble  <[email protected]>
+
         Integrate libwebm into the libwebrtc project.
         https://bugs.webkit.org/show_bug.cgi?id=214410
 

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/api/video_frame_buffer/RTCNativeI420Buffer.mm (264495 => 264496)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/api/video_frame_buffer/RTCNativeI420Buffer.mm	2020-07-17 03:36:05 UTC (rev 264495)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/api/video_frame_buffer/RTCNativeI420Buffer.mm	2020-07-17 03:36:07 UTC (rev 264496)
@@ -109,30 +109,4 @@
   return _i420Buffer;
 }
 
-#pragma mark - Debugging
-
-#if !defined(NDEBUG) && defined(WEBRTC_IOS)
-- (id)debugQuickLookObject {
-  UIGraphicsBeginImageContext(CGSizeMake(_i420Buffer->width(), _i420Buffer->height()));
-  CGContextRef c = UIGraphicsGetCurrentContext();
-  uint8_t *ctxData = (uint8_t *)CGBitmapContextGetData(c);
-
-  libyuv::I420ToARGB(_i420Buffer->DataY(),
-                     _i420Buffer->StrideY(),
-                     _i420Buffer->DataU(),
-                     _i420Buffer->StrideU(),
-                     _i420Buffer->DataV(),
-                     _i420Buffer->StrideV(),
-                     ctxData,
-                     CGBitmapContextGetBytesPerRow(c),
-                     CGBitmapContextGetWidth(c),
-                     CGBitmapContextGetHeight(c));
-
-  UIImage *image = UIGraphicsGetImageFromCurrentImageContext();
-  UIGraphicsEndImageContext();
-
-  return image;
-}
-#endif
-
 @end
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to