Title: [264546] trunk/Source/WebKit
Revision
264546
Author
[email protected]
Date
2020-07-17 16:07:44 -0700 (Fri, 17 Jul 2020)

Log Message

Add Launch Services database update logging
https://bugs.webkit.org/show_bug.cgi?id=214500

Reviewed by Geoffrey Garen.

Log if the WebContent process is waiting a considerable amount of time for the initial update of the Launch Services database.

No new tests, since this patch is not introducing any behavior change.

* WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::platformDidReceiveLoadParameters):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (264545 => 264546)


--- trunk/Source/WebKit/ChangeLog	2020-07-17 23:06:00 UTC (rev 264545)
+++ trunk/Source/WebKit/ChangeLog	2020-07-17 23:07:44 UTC (rev 264546)
@@ -1,3 +1,17 @@
+2020-07-17  Per Arne Vollan  <[email protected]>
+
+        Add Launch Services database update logging
+        https://bugs.webkit.org/show_bug.cgi?id=214500
+
+        Reviewed by Geoffrey Garen.
+
+        Log if the WebContent process is waiting a considerable amount of time for the initial update of the Launch Services database.
+
+        No new tests, since this patch is not introducing any behavior change.
+
+        * WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
+        (WebKit::WebPage::platformDidReceiveLoadParameters):
+
 2020-07-17  Brent Fulgham  <[email protected]>
 
         Remove logging for necessary sysctl call

Modified: trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm (264545 => 264546)


--- trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm	2020-07-17 23:06:00 UTC (rev 264545)
+++ trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm	2020-07-17 23:07:44 UTC (rev 264546)
@@ -64,8 +64,10 @@
 
 void WebPage::platformDidReceiveLoadParameters(const LoadParameters& parameters)
 {
-    bool databaseUpdated =  LaunchServicesDatabaseManager::singleton().waitForDatabaseUpdate(5_s);
+    bool databaseUpdated = LaunchServicesDatabaseManager::singleton().waitForDatabaseUpdate(5_s);
     ASSERT_UNUSED(databaseUpdated, databaseUpdated);
+    if (!databaseUpdated)
+        WTFLogAlways("Timed out waiting for Launch Services database update.");
 
     m_dataDetectionContext = parameters.dataDetectionContext;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to