Title: [264598] trunk/Source/WebKit
- Revision
- 264598
- Author
- [email protected]
- Date
- 2020-07-20 06:41:52 -0700 (Mon, 20 Jul 2020)
Log Message
Some classes have final destructors but are non-final
https://bugs.webkit.org/show_bug.cgi?id=214549
Reviewed by Youenn Fablet.
No new tests needed.
* NetworkProcess/ServiceWorker/WebSWServerConnection.h: Mark WebSWServerConnection
class as final.
* WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h: Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264597 => 264598)
--- trunk/Source/WebKit/ChangeLog 2020-07-20 13:37:05 UTC (rev 264597)
+++ trunk/Source/WebKit/ChangeLog 2020-07-20 13:41:52 UTC (rev 264598)
@@ -1,3 +1,16 @@
+2020-07-20 Adrian Perez de Castro <[email protected]>
+
+ Some classes have final destructors but are non-final
+ https://bugs.webkit.org/show_bug.cgi?id=214549
+
+ Reviewed by Youenn Fablet.
+
+ No new tests needed.
+
+ * NetworkProcess/ServiceWorker/WebSWServerConnection.h: Mark WebSWServerConnection
+ class as final.
+ * WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h: Ditto.
+
2020-07-20 Carlos Garcia Campos <[email protected]>
valgrind claims uninitialized memory when opening inspector (WebKit::InspectorBrowserAgent::enable(WTF::String&))
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h (264597 => 264598)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h 2020-07-20 13:37:05 UTC (rev 264597)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h 2020-07-20 13:41:52 UTC (rev 264598)
@@ -61,7 +61,7 @@
class NetworkResourceLoader;
class ServiceWorkerFetchTask;
-class WebSWServerConnection : public WebCore::SWServer::Connection, public IPC::MessageSender, public IPC::MessageReceiver {
+class WebSWServerConnection final : public WebCore::SWServer::Connection, public IPC::MessageSender, public IPC::MessageReceiver {
public:
WebSWServerConnection(NetworkProcess&, WebCore::SWServer&, IPC::Connection&, WebCore::ProcessIdentifier);
WebSWServerConnection(const WebSWServerConnection&) = delete;
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h (264597 => 264598)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h 2020-07-20 13:37:05 UTC (rev 264597)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h 2020-07-20 13:41:52 UTC (rev 264598)
@@ -29,7 +29,7 @@
namespace WebKit {
-class WebMessagePortChannelProvider : public WebCore::MessagePortChannelProvider {
+class WebMessagePortChannelProvider final : public WebCore::MessagePortChannelProvider {
WTF_MAKE_FAST_ALLOCATED;
public:
static WebMessagePortChannelProvider& singleton();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
