Title: [264747] trunk/Source
- Revision
- 264747
- Author
- jer.no...@apple.com
- Date
- 2020-07-22 21:52:32 -0700 (Wed, 22 Jul 2020)
Log Message
[Cocoa] Add feature flag for WebM & VP9
https://bugs.webkit.org/show_bug.cgi?id=214672
<rdar://problem/65959506>
Reviewed by Beth Dakin.
Source/WebKit:
* FeatureFlags/WebKit.plist:
* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultVP9DecoderEnabled):
(WebKit::defaultWebMParserEnabled):
* Shared/WebPreferencesDefaultValues.h:
Source/WTF:
* wtf/PlatformEnableCocoa.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (264746 => 264747)
--- trunk/Source/WTF/ChangeLog 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WTF/ChangeLog 2020-07-23 04:52:32 UTC (rev 264747)
@@ -1,3 +1,13 @@
+2020-07-22 Jer Noble <jer.no...@apple.com>
+
+ [Cocoa] Add feature flag for WebM & VP9
+ https://bugs.webkit.org/show_bug.cgi?id=214672
+ <rdar://problem/65959506>
+
+ Reviewed by Beth Dakin.
+
+ * wtf/PlatformEnableCocoa.h:
+
2020-07-22 Conrad Shultz <conrad_shu...@apple.com>
Update macOS Version macros
Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (264746 => 264747)
--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-07-23 04:52:32 UTC (rev 264747)
@@ -530,6 +530,10 @@
#define ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN 1
#endif
+#if !defined(ENABLE_VP9) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
+#define ENABLE_VP9 1
+#endif
+
#if !defined(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS)
#define ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS 1
#endif
Modified: trunk/Source/WebKit/ChangeLog (264746 => 264747)
--- trunk/Source/WebKit/ChangeLog 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WebKit/ChangeLog 2020-07-23 04:52:32 UTC (rev 264747)
@@ -1,3 +1,18 @@
+2020-07-22 Jer Noble <jer.no...@apple.com>
+
+ [Cocoa] Add feature flag for WebM & VP9
+ https://bugs.webkit.org/show_bug.cgi?id=214672
+ <rdar://problem/65959506>
+
+ Reviewed by Beth Dakin.
+
+ * FeatureFlags/WebKit.plist:
+ * Shared/WebPreferences.yaml:
+ * Shared/WebPreferencesDefaultValues.cpp:
+ (WebKit::defaultVP9DecoderEnabled):
+ (WebKit::defaultWebMParserEnabled):
+ * Shared/WebPreferencesDefaultValues.h:
+
2020-07-22 Conrad Shultz <conrad_shu...@apple.com>
Update macOS Version macros
Modified: trunk/Source/WebKit/FeatureFlags/WebKit.plist (264746 => 264747)
--- trunk/Source/WebKit/FeatureFlags/WebKit.plist 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WebKit/FeatureFlags/WebKit.plist 2020-07-23 04:52:32 UTC (rev 264747)
@@ -47,5 +47,15 @@
<key>Enabled</key>
<false/>
</dict>
+ <key>vp9_decoder</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>webm_parser</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (264746 => 264747)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-07-23 04:52:32 UTC (rev 264747)
@@ -662,20 +662,21 @@
VP9DecoderEnabled:
type: bool
- defaultValue: false
+ defaultValue: defaultVP9DecoderEnabled()
webcoreBinding: none
humanReadableName: "VP9 decoder"
humanReadableDescription: "Enable VP9 decoder"
category: experimental
+ condition: ENABLE(VP9)
WebMParserEnabled:
type: bool
- defaultValue: false
+ defaultValue: defaultWebMParserEnabled()
webcoreBinding: RuntimeEnabledFeatures
humanReadableName: "WebM MSE parser"
humanReadableDescription: "Enable WebM MSE parser"
category: experimental
- condition: ENABLE(MEDIA_SOURCE)
+ condition: ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
UseLegacyTextAlignPositionedElementBehavior:
type: bool
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (264746 => 264747)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-07-23 04:52:32 UTC (rev 264747)
@@ -243,4 +243,26 @@
#endif // ENABLE(WEBXR)
+#if ENABLE(VP9)
+bool defaultVP9DecoderEnabled()
+{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+ return isFeatureFlagEnabled("vp9_decoder");
+#endif
+
+ return true;
+}
+#endif
+
+#if ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
+bool defaultWebMParserEnabled()
+{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+ return isFeatureFlagEnabled("webm_parser");
+#endif
+
+ return true;
+}
+#endif
+
} // namespace WebKit
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (264746 => 264747)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2020-07-23 04:52:32 UTC (rev 264747)
@@ -362,4 +362,12 @@
bool defaultWebXREnabled();
#endif
+#if ENABLE(VP9)
+bool defaultVP9DecoderEnabled();
+#endif
+
+#if ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
+bool defaultWebMParserEnabled();
+#endif
+
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
