Title: [265263] trunk/Source/WebKit
- Revision
- 265263
- Author
- bfulg...@apple.com
- Date
- 2020-08-04 15:39:21 -0700 (Tue, 04 Aug 2020)
Log Message
Limit 'com.apple.webkit.microphone' use to macOS and MacCatalyst
https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>
Reviewed by Eric Carlson.
We only need the 'com.apple.webkit.microphone' Sandbox Extension at startup on
macOS and MacCatalyst (and even on those platforms, only until <rdar://problem/29448368>
is fixed).
We should not issue this extension on the iOS family of targets.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (265262 => 265263)
--- trunk/Source/WebKit/ChangeLog 2020-08-04 22:18:21 UTC (rev 265262)
+++ trunk/Source/WebKit/ChangeLog 2020-08-04 22:39:21 UTC (rev 265263)
@@ -1,3 +1,20 @@
+2020-08-04 Brent Fulgham <bfulg...@apple.com>
+
+ Limit 'com.apple.webkit.microphone' use to macOS and MacCatalyst
+ https://bugs.webkit.org/show_bug.cgi?id=215139
+ <rdar://problem/66501746>
+
+ Reviewed by Eric Carlson.
+
+ We only need the 'com.apple.webkit.microphone' Sandbox Extension at startup on
+ macOS and MacCatalyst (and even on those platforms, only until <rdar://problem/29448368>
+ is fixed).
+
+ We should not issue this extension on the iOS family of targets.
+
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::platformInitializeWebProcess):
+
2020-08-04 Per Arne Vollan <pvol...@apple.com>
[iOS Simulator] Assert under WebPage::platformDidReceiveLoadParameters
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (265262 => 265263)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-08-04 22:18:21 UTC (rev 265262)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-08-04 22:39:21 UTC (rev 265263)
@@ -381,10 +381,12 @@
parameters.webKitLoggingChannels = [[NSUserDefaults standardUserDefaults] stringForKey:@"WebKit2Logging"];
#endif
+#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
// FIXME: Remove this and related parameter when <rdar://problem/29448368> is fixed.
if (isSafari && mediaDevicesEnabled && !m_defaultPageGroup->preferences().captureAudioInUIProcessEnabled() && !m_defaultPageGroup->preferences().captureAudioInGPUProcessEnabled())
SandboxExtension::createHandleForGenericExtension("com.apple.webkit.microphone"_s, parameters.audioCaptureExtensionHandle);
#endif
+#endif
#if ENABLE(RESOURCE_LOAD_STATISTICS) && !RELEASE_LOG_DISABLED
parameters.shouldLogUserInteraction = [defaults boolForKey:WebKitLogCookieInformationDefaultsKey];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
