Title: [265357] trunk/Source/WebCore
- Revision
- 265357
- Author
- peng.l...@apple.com
- Date
- 2020-08-06 17:23:50 -0700 (Thu, 06 Aug 2020)
Log Message
Web process crashes at WebCore::FullscreenManager::didExitFullscreen
https://bugs.webkit.org/show_bug.cgi?id=215243
Reviewed by Eric Carlson.
No new tests, no functional change.
* dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::didExitFullscreen):
m_fullscreenElement might be nullptr when fullscreenOrPendingElement() is not nullptr.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (265356 => 265357)
--- trunk/Source/WebCore/ChangeLog 2020-08-07 00:19:15 UTC (rev 265356)
+++ trunk/Source/WebCore/ChangeLog 2020-08-07 00:23:50 UTC (rev 265357)
@@ -1,3 +1,16 @@
+2020-08-06 Peng Liu <peng.l...@apple.com>
+
+ Web process crashes at WebCore::FullscreenManager::didExitFullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=215243
+
+ Reviewed by Eric Carlson.
+
+ No new tests, no functional change.
+
+ * dom/FullscreenManager.cpp:
+ (WebCore::FullscreenManager::didExitFullscreen):
+ m_fullscreenElement might be nullptr when fullscreenOrPendingElement() is not nullptr.
+
2020-08-06 Wenson Hsieh <wenson_hs...@apple.com>
WeakPtr threading assertion on editing/undo-manager/undo-manager-delete-stale-undo-items.html
Modified: trunk/Source/WebCore/dom/FullscreenManager.cpp (265356 => 265357)
--- trunk/Source/WebCore/dom/FullscreenManager.cpp 2020-08-07 00:19:15 UTC (rev 265356)
+++ trunk/Source/WebCore/dom/FullscreenManager.cpp 2020-08-07 00:23:50 UTC (rev 265357)
@@ -421,8 +421,10 @@
if (!hasLivingRenderTree() || backForwardCacheState() != Document::NotInBackForwardCache)
return;
fullscreenElement->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(false);
- m_fullscreenElement->didStopBeingFullscreenElement();
+ if (m_fullscreenElement)
+ m_fullscreenElement->didStopBeingFullscreenElement();
+
m_areKeysEnabledInFullscreen = false;
unwrapFullscreenRenderer(m_fullscreenRenderer.get(), m_fullscreenElement.get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
