Title: [265609] trunk/Tools
- Revision
- 265609
- Author
- aakash_j...@apple.com
- Date
- 2020-08-13 08:59:34 -0700 (Thu, 13 Aug 2020)
Log Message
[ews] Improve wording for test failure email
https://bugs.webkit.org/show_bug.cgi?id=215449
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Pluralize 'test failure' accordingly.
* BuildSlaveSupport/ews-build/send_email.py:
(send_email): Drive-by fix.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/send_email.py (265608 => 265609)
--- trunk/Tools/BuildSlaveSupport/ews-build/send_email.py 2020-08-13 15:50:04 UTC (rev 265608)
+++ trunk/Tools/BuildSlaveSupport/ews-build/send_email.py 2020-08-13 15:59:34 UTC (rev 265609)
@@ -36,10 +36,10 @@
if is_test_mode_enabled:
return
if not to_emails:
- print('Skipping email since no recipient is specified')
+ print('Error: skipping email since no recipient is specified')
return
if not subject or not text:
- print('Skipping email since no subject or text is specified')
+ print('Error: skipping email since no subject or text is specified')
return
text = text.encode('utf-8')
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (265608 => 265609)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-08-13 15:50:04 UTC (rev 265608)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-08-13 15:59:34 UTC (rev 265609)
@@ -2154,11 +2154,12 @@
history_url = '{}?suite=layout-tests&test={}'.format(RESULTS_DB_URL, test_name)
test_names_string += '\n- {} (<a href="" history</a>)'.format(test_name, history_url)
+ pluralSuffix = 's' if len(test_names) > 1 else ''
email_subject = 'Layout test failure for Patch {}: {} '.format(patch_id, bug_title)
- email_text = 'EWS has detected test failure on {} while testing Patch {}'.format(builder_name, patch_id)
+ email_text = 'EWS has detected layout test failure{} on {} while testing Patch {}'.format(pluralSuffix, builder_name, patch_id)
email_text += ' for <a href="" {}</a>.'.format(Bugzilla.bug_url(bug_id), bug_id)
email_text += '\n\nFull details are available at: {}\n\nPatch author: {}'.format(build_url, patch_author)
- email_text += '\n\nLayout test failure:\n{}'.format(test_names_string)
+ email_text += '\n\nLayout test failure{}:\n{}'.format(pluralSuffix, test_names_string)
email_text += '\n\nTo unsubscrible from these notifications or to provide any feedback please email aakash_j...@apple.com'
send_email([patch_author], email_subject, email_text)
except Exception as e:
Modified: trunk/Tools/ChangeLog (265608 => 265609)
--- trunk/Tools/ChangeLog 2020-08-13 15:50:04 UTC (rev 265608)
+++ trunk/Tools/ChangeLog 2020-08-13 15:59:34 UTC (rev 265609)
@@ -1,3 +1,15 @@
+2020-08-13 Aakash Jain <aakash_j...@apple.com>
+
+ [ews] Improve wording for test failure email
+ https://bugs.webkit.org/show_bug.cgi?id=215449
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Pluralize 'test failure' accordingly.
+ * BuildSlaveSupport/ews-build/send_email.py:
+ (send_email): Drive-by fix.
+
2020-08-13 Jonathan Bedard <jbed...@apple.com>
[webkitpy] Use webkitcorepy's auto installer for coverage
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
