Diff
Modified: trunk/LayoutTests/ChangeLog (265687 => 265688)
--- trunk/LayoutTests/ChangeLog 2020-08-14 18:55:09 UTC (rev 265687)
+++ trunk/LayoutTests/ChangeLog 2020-08-14 18:56:07 UTC (rev 265688)
@@ -1,3 +1,11 @@
+2020-08-14 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Unreviewed, revert r265213 and r265441
+ https://bugs.webkit.org/show_bug.cgi?id=215089
+
+ * editing/selection/ios/select-all-non-editable-text-using-keyboard-expected.txt:
+ * editing/selection/ios/select-all-non-editable-text-using-keyboard.html:
+
2020-08-14 Hector Lopez <hector_i_lo...@apple.com>
[ macOS iOS ] imported/w3c/web-platform-tests/user-timing/measure_navigation_timing.html is a flaky failure
Modified: trunk/LayoutTests/editing/selection/ios/select-all-non-editable-text-using-keyboard-expected.txt (265687 => 265688)
--- trunk/LayoutTests/editing/selection/ios/select-all-non-editable-text-using-keyboard-expected.txt 2020-08-14 18:55:09 UTC (rev 265687)
+++ trunk/LayoutTests/editing/selection/ios/select-all-non-editable-text-using-keyboard-expected.txt 2020-08-14 18:56:07 UTC (rev 265688)
@@ -1,5 +1,3 @@
-CONSOLE MESSAGE: Triggering 'select all' via key command.
-CONSOLE MESSAGE: Done waiting for selectionchange.
Tests pressing Command + a to select all non-editable text.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/editing/selection/ios/select-all-non-editable-text-using-keyboard.html (265687 => 265688)
--- trunk/LayoutTests/editing/selection/ios/select-all-non-editable-text-using-keyboard.html 2020-08-14 18:55:09 UTC (rev 265687)
+++ trunk/LayoutTests/editing/selection/ios/select-all-non-editable-text-using-keyboard.html 2020-08-14 18:56:07 UTC (rev 265688)
@@ -29,9 +29,7 @@
{
toggleOnlyShowTestContainer();
- console.log("Triggering 'select all' via key command.");
await UIHelper.callFunctionAndWaitForEvent(() => window.testRunner && UIHelper.keyDown("a", ["metaKey"]) , document, "selectionchange");
- console.log("Done waiting for selectionchange.");
shouldBeEqualToString("window.getSelection().toString()", "Here's to the crazy ones.\n\nThe misfits.\n\nThe rebels.");
toggleOnlyShowTestContainer();
Modified: trunk/Source/WebKit/ChangeLog (265687 => 265688)
--- trunk/Source/WebKit/ChangeLog 2020-08-14 18:55:09 UTC (rev 265687)
+++ trunk/Source/WebKit/ChangeLog 2020-08-14 18:56:07 UTC (rev 265688)
@@ -1,3 +1,13 @@
+2020-08-14 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Unreviewed, revert r265213 and r265441
+ https://bugs.webkit.org/show_bug.cgi?id=215089
+
+ This logging is no longer needed, since the test seems to be passing reliably in internal automation now.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView selectAllForWebView:]):
+
2020-08-13 Carlos Garcia Campos <cgar...@igalia.com>
[GTK4] Notify the web process on drag leave
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (265687 => 265688)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-08-14 18:55:09 UTC (rev 265687)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-08-14 18:56:07 UTC (rev 265688)
@@ -3581,7 +3581,6 @@
- (void)selectAllForWebView:(id)sender
{
- WTFLogAlways("%s", __PRETTY_FUNCTION__);
[_textInteractionAssistant selectAll:sender];
_page->selectAll();
}
Modified: trunk/Tools/ChangeLog (265687 => 265688)
--- trunk/Tools/ChangeLog 2020-08-14 18:55:09 UTC (rev 265687)
+++ trunk/Tools/ChangeLog 2020-08-14 18:56:07 UTC (rev 265688)
@@ -1,3 +1,11 @@
+2020-08-14 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Unreviewed, revert r265213 and r265441
+ https://bugs.webkit.org/show_bug.cgi?id=215089
+
+ * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+ (WTR::UIScriptControllerIOS::keyDown):
+
2020-08-14 Philippe Normand <pnorm...@igalia.com>
[Flatpak SK] Enable GNOME keyring support in subversion
Modified: trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm (265687 => 265688)
--- trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2020-08-14 18:55:09 UTC (rev 265687)
+++ trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2020-08-14 18:56:07 UTC (rev 265688)
@@ -554,12 +554,9 @@
String inputString = toWTFString(toWK(character));
auto modifierFlags = parseModifierArray(m_context->jsContext(), modifierArray);
- for (auto& modifierFlag : modifierFlags) {
- WTFLogAlways("Sending modifier keydown: %s", modifierFlag.utf8().data());
+ for (auto& modifierFlag : modifierFlags)
[[HIDEventGenerator sharedHIDEventGenerator] keyDown:modifierFlag];
- }
- WTFLogAlways("Sending keydown for input string '%s'", inputString.utf8().data());
[[HIDEventGenerator sharedHIDEventGenerator] keyDown:inputString];
[[HIDEventGenerator sharedHIDEventGenerator] keyUp:inputString];
