Title: [266464] trunk/Source/WebInspectorUI
Revision
266464
Author
drou...@apple.com
Date
2020-09-02 08:49:11 -0700 (Wed, 02 Sep 2020)

Log Message

Web Inspector: Graphics: reloading the page doesn't automatically deselect shaders if they are shown
https://bugs.webkit.org/show_bug.cgi?id=216054
<rdar://problem/68167882>

Reviewed by Brian Burg.

* UserInterface/Views/GraphicsTabContentView.js:
(WI.GraphicsTabContentView.prototype._removeCanvas):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (266463 => 266464)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-09-02 15:48:26 UTC (rev 266463)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-09-02 15:49:11 UTC (rev 266464)
@@ -1,5 +1,16 @@
 2020-09-02  Devin Rousso  <drou...@apple.com>
 
+        Web Inspector: Graphics: reloading the page doesn't automatically deselect shaders if they are shown
+        https://bugs.webkit.org/show_bug.cgi?id=216054
+        <rdar://problem/68167882>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/GraphicsTabContentView.js:
+        (WI.GraphicsTabContentView.prototype._removeCanvas):
+
+2020-09-02  Devin Rousso  <drou...@apple.com>
+
         Web Inspector: Timelines: re-enabling the _javascript_ Allocations timeline doesn't show previously captured heap snapshots in the table
         https://bugs.webkit.org/show_bug.cgi?id=216057
         <rdar://problem/68172848>

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.js (266463 => 266464)


--- trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.js	2020-09-02 15:48:26 UTC (rev 266463)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.js	2020-09-02 15:49:11 UTC (rev 266464)
@@ -235,8 +235,10 @@
         this._canvasesTreeElement.removeChild(treeElement);
 
         let currentContentView = this.contentBrowser.currentContentView;
-        if (currentContentView instanceof WI.CanvasContentView)
+        if (currentContentView instanceof WI.CanvasContentView && canvas === currentContentView.representedObject)
             WI.showRepresentedObject(WI.canvasManager.canvasCollection);
+        else if (currentContentView instanceof WI.ShaderProgramContentView && canvas === currentContentView.representedObject.canvas)
+            WI.showRepresentedObject(WI.canvasManager.canvasCollection);
         else if (currentContentView instanceof WI.RecordingContentView && canvas.recordingCollection.has(currentContentView.representedObject))
             this.contentBrowser.updateHierarchicalPathForCurrentContentView();
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to