Title: [266465] trunk/Source/WebInspectorUI
Revision
266465
Author
drou...@apple.com
Date
2020-09-02 08:50:33 -0700 (Wed, 02 Sep 2020)

Log Message

Web Inspector: REGRESSION(?): Timelines: Frames: clicking a record bar to select it when another record bar is already selected instead removes all selections
https://bugs.webkit.org/show_bug.cgi?id=216045
<rdar://problem/68156740>

Reviewed by Brian Burg.

* UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WI.RenderingFrameTimelineOverviewGraph.prototype._mouseClicked):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (266464 => 266465)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-09-02 15:49:11 UTC (rev 266464)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-09-02 15:50:33 UTC (rev 266465)
@@ -1,5 +1,16 @@
 2020-09-02  Devin Rousso  <drou...@apple.com>
 
+        Web Inspector: REGRESSION(?): Timelines: Frames: clicking a record bar to select it when another record bar is already selected instead removes all selections
+        https://bugs.webkit.org/show_bug.cgi?id=216045
+        <rdar://problem/68156740>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
+        (WI.RenderingFrameTimelineOverviewGraph.prototype._mouseClicked):
+
+2020-09-02  Devin Rousso  <drou...@apple.com>
+
         Web Inspector: Graphics: reloading the page doesn't automatically deselect shaders if they are shown
         https://bugs.webkit.org/show_bug.cgi?id=216054
         <rdar://problem/68167882>

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js (266464 => 266465)


--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js	2020-09-02 15:49:11 UTC (rev 266464)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js	2020-09-02 15:50:33 UTC (rev 266465)
@@ -261,6 +261,9 @@
         if (newSelectedRecord[WI.RenderingFrameTimelineOverviewGraph.RecordWasFilteredSymbol])
             return;
 
+        // Ensure that the container "click" listener added by `WI.TimelineOverview` isn't called.
+        event.__timelineRecordClickEventHandled = true;
+
         if (this.selectedRecord === newSelectedRecord)
             return;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to