Title: [266475] trunk/LayoutTests
- Revision
- 266475
- Author
- drou...@apple.com
- Date
- 2020-09-02 10:38:55 -0700 (Wed, 02 Sep 2020)
Log Message
REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215614
<rdar://problem/67333849>
Reviewed by Eric Carlson.
* media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html:
* media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl-expected.txt:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (266474 => 266475)
--- trunk/LayoutTests/ChangeLog 2020-09-02 17:37:47 UTC (rev 266474)
+++ trunk/LayoutTests/ChangeLog 2020-09-02 17:38:55 UTC (rev 266475)
@@ -1,3 +1,16 @@
+2020-09-02 Devin Rousso <drou...@apple.com>
+
+ REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=215614
+ <rdar://problem/67333849>
+
+ Reviewed by Eric Carlson.
+
+ * media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html:
+ * media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl-expected.txt:
+
+ * platform/mac/TestExpectations:
+
2020-09-02 Youenn Fablet <you...@apple.com>
Introduce a C++ chain of operations in RTCPeerConnection
Modified: trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl-expected.txt (266474 => 266475)
--- trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl-expected.txt 2020-09-02 17:37:47 UTC (rev 266474)
+++ trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl-expected.txt 2020-09-02 17:38:55 UTC (rev 266475)
@@ -13,7 +13,7 @@
width = 600
muted = false
usesLTRUserInterfaceLayoutDirection = false
-PASS mediaControls.muteButton.iconName became Icons.Volume
+PASS mediaControls.muteButton.iconName became Icons.VolumeRTL
PASS mediaControls.topLeftControlsBar.children[1].children became [mediaControls.pipButton, mediaControls.fullscreenButton]
PASS getComputedStyle(mediaControls.topLeftControlsBar.element).right became "6px"
Modified: trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html (266474 => 266475)
--- trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html 2020-09-02 17:37:47 UTC (rev 266474)
+++ trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html 2020-09-02 17:38:55 UTC (rev 266475)
@@ -9,7 +9,6 @@
window.jsTestIsAsync = true;
const mediaControls = new MacOSInlineMediaControls({ width: 600, height: 250 });
-mediaControls.usesLTRUserInterfaceLayoutDirection = true;
mediaControls.element.style.position = "relative";
document.body.appendChild(mediaControls.element);
@@ -21,6 +20,7 @@
debug("width = 600");
debug("muted = false");
debug("usesLTRUserInterfaceLayoutDirection = true");
+ mediaControls.usesLTRUserInterfaceLayoutDirection = true;
shouldBecomeEqual("mediaControls.muteButton.iconName", "Icons.Volume", () => {
shouldBecomeEqual("mediaControls.topLeftControlsBar.children[1].children", "[mediaControls.fullscreenButton, mediaControls.pipButton]", () => {
shouldBecomeEqualToString("getComputedStyle(mediaControls.topLeftControlsBar.element).left", "6px", step2);
@@ -35,7 +35,7 @@
debug("muted = false");
debug("usesLTRUserInterfaceLayoutDirection = false");
mediaControls.usesLTRUserInterfaceLayoutDirection = false;
- shouldBecomeEqual("mediaControls.muteButton.iconName", "Icons.Volume", () => {
+ shouldBecomeEqual("mediaControls.muteButton.iconName", "Icons.VolumeRTL", () => {
shouldBecomeEqual("mediaControls.topLeftControlsBar.children[1].children", "[mediaControls.pipButton, mediaControls.fullscreenButton]", () => {
shouldBecomeEqualToString("getComputedStyle(mediaControls.topLeftControlsBar.element).right", "6px", step3);
});
Modified: trunk/LayoutTests/platform/mac/TestExpectations (266474 => 266475)
--- trunk/LayoutTests/platform/mac/TestExpectations 2020-09-02 17:37:47 UTC (rev 266474)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2020-09-02 17:38:55 UTC (rev 266475)
@@ -2186,8 +2186,6 @@
webkit.org/b/215587 media/modern-media-controls/volume-down-support/volume-down-support.html [ Pass Timeout ]
-webkit.org/b/215614 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html [ Pass Timeout ]
-
webkit.org/b/215649 accessibility/mac/select-element-selection-with-optgroups.html [ Pass Failure ]
webkit.org/b/215723 fast/repaint/list-item-equal-style-change-no-repaint.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
