Title: [266485] trunk/Source
Revision
266485
Author
timothy_hor...@apple.com
Date
2020-09-02 13:41:46 -0700 (Wed, 02 Sep 2020)

Log Message

iPad + Trackpad: JW Library highlighting and edit menus don't appear
https://bugs.webkit.org/show_bug.cgi?id=216086

Reviewed by Wenson Hsieh.

Source/WebCore:

* platform/RuntimeApplicationChecks.h:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isJWLibrary):

Source/WebKit:

* UIProcess/ios/WKContentViewInteraction.mm:
(applicationIsKnownToIgnoreMouseEvents):
Add JW Library to the list.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (266484 => 266485)


--- trunk/Source/WebCore/ChangeLog	2020-09-02 20:32:35 UTC (rev 266484)
+++ trunk/Source/WebCore/ChangeLog	2020-09-02 20:41:46 UTC (rev 266485)
@@ -1,3 +1,14 @@
+2020-09-02  Timothy Horton  <timothy_hor...@apple.com>
+
+        iPad + Trackpad: JW Library highlighting and edit menus don't appear
+        https://bugs.webkit.org/show_bug.cgi?id=216086
+
+        Reviewed by Wenson Hsieh.
+
+        * platform/RuntimeApplicationChecks.h:
+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+        (WebCore::IOSApplication::isJWLibrary):
+
 2020-09-02  Chris Dumez  <cdu...@apple.com>
 
         New AutoParam timeline events should have their startTime adjusted when they are in the past

Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (266484 => 266485)


--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h	2020-09-02 20:32:35 UTC (rev 266484)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h	2020-09-02 20:41:46 UTC (rev 266485)
@@ -111,6 +111,7 @@
 WEBCORE_EXPORT bool isFIFACompanion();
 WEBCORE_EXPORT bool isNoggin();
 WEBCORE_EXPORT bool isOKCupid();
+WEBCORE_EXPORT bool isJWLibrary();
 
 } // IOSApplication
 

Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (266484 => 266485)


--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm	2020-09-02 20:32:35 UTC (rev 266484)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm	2020-09-02 20:41:46 UTC (rev 266485)
@@ -422,6 +422,12 @@
     return isOKCupid;
 }
 
+bool IOSApplication::isJWLibrary()
+{
+    static bool isJWLibrary = applicationBundleIsEqualTo("org.jw.jwlibrary"_s);
+    return isJWLibrary;
+}
+
 #endif
 
 } // namespace WebCore

Modified: trunk/Source/WebKit/ChangeLog (266484 => 266485)


--- trunk/Source/WebKit/ChangeLog	2020-09-02 20:32:35 UTC (rev 266484)
+++ trunk/Source/WebKit/ChangeLog	2020-09-02 20:41:46 UTC (rev 266485)
@@ -1,3 +1,14 @@
+2020-09-02  Timothy Horton  <timothy_hor...@apple.com>
+
+        iPad + Trackpad: JW Library highlighting and edit menus don't appear
+        https://bugs.webkit.org/show_bug.cgi?id=216086
+
+        Reviewed by Wenson Hsieh.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (applicationIsKnownToIgnoreMouseEvents):
+        Add JW Library to the list.
+
 2020-09-02  Youenn Fablet  <you...@apple.com>
 
         Introduce a ThreadableWebSocketChannel identifier

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (266484 => 266485)


--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-09-02 20:32:35 UTC (rev 266484)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-09-02 20:41:46 UTC (rev 266485)
@@ -8577,7 +8577,8 @@
     if (!WebKit::linkedOnOrAfter(WebKit::SDKVersion::FirstVersionWithiOSAppsOnMacOS)) {
         if (WebCore::IOSApplication::isFIFACompanion() // <rdar://problem/67093487>
             || WebCore::IOSApplication::isNoggin() // <rdar://problem/64830335>
-            || WebCore::IOSApplication::isOKCupid()) { // <rdar://problem/65698496>
+            || WebCore::IOSApplication::isOKCupid() // <rdar://problem/65698496>
+            || WebCore::IOSApplication::isJWLibrary()) { // <rdar://problem/68104852>
             warningVersion = "14.2";
             return YES;
         }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to