Title: [266493] trunk/Source/WebKit
Revision
266493
Author
wilan...@apple.com
Date
2020-09-02 15:44:52 -0700 (Wed, 02 Sep 2020)

Log Message

Remove custom domain from SameSite=strict jail protection
https://bugs.webkit.org/show_bug.cgi?id=216083
<rdar://problem/68220223>

Reviewed by Alex Christensen.

No new tests. This was a site-specific opt-in rule. The feature
itself has tests.

* NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::shouldEnforceSameSiteStrictForSpecificDomain const):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (266492 => 266493)


--- trunk/Source/WebKit/ChangeLog	2020-09-02 22:11:59 UTC (rev 266492)
+++ trunk/Source/WebKit/ChangeLog	2020-09-02 22:44:52 UTC (rev 266493)
@@ -1,3 +1,17 @@
+2020-09-02  John Wilander  <wilan...@apple.com>
+
+        Remove custom domain from SameSite=strict jail protection
+        https://bugs.webkit.org/show_bug.cgi?id=216083
+        <rdar://problem/68220223>
+
+        Reviewed by Alex Christensen.
+
+        No new tests. This was a site-specific opt-in rule. The feature
+        itself has tests.
+
+        * NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
+        (WebKit::ResourceLoadStatisticsStore::shouldEnforceSameSiteStrictForSpecificDomain const):
+
 2020-09-01  Darin Adler  <da...@apple.com>
 
         Remove comparePositions and make VisiblePosition improvements

Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp (266492 => 266493)


--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp	2020-09-02 22:11:59 UTC (rev 266492)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp	2020-09-02 22:44:52 UTC (rev 266493)
@@ -449,13 +449,9 @@
 
 bool ResourceLoadStatisticsStore::shouldEnforceSameSiteStrictForSpecificDomain(const RegistrableDomain& domain) const
 {
-    static NeverDestroyed<HashSet<RegistrableDomain>> domains = [] {
-        HashSet<RegistrableDomain> set;
-        set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("yahoo.co.jp"_s));
-        return set;
-    }();
-
-    return domains.get().contains(domain);
+    // We currently know of no domains that need this protection.
+    UNUSED_PARAM(domain);
+    return false;
 }
 
 void ResourceLoadStatisticsStore::setMaxStatisticsEntries(size_t maximumEntryCount)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to