Title: [266741] trunk/Tools
- Revision
- 266741
- Author
- aakash_j...@apple.com
- Date
- 2020-09-08 12:29:26 -0700 (Tue, 08 Sep 2020)
Log Message
EWS should set cq- flag when a patch fails to build or introduces layout-test failures
https://bugs.webkit.org/show_bug.cgi?id=214194
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.start): Set cq- on patch when patch fails to build.
(AnalyzeLayoutTestsResults.report_failure): Set cq- on patch when patch introduces layout-test failures.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (266740 => 266741)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-09-08 19:25:13 UTC (rev 266740)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-09-08 19:29:26 UTC (rev 266741)
@@ -1443,12 +1443,12 @@
self.send_email_for_new_build_failure()
self.descriptionDone = message
+ self.setProperty('build_finish_summary', message)
if self.getProperty('buildername', '').lower() == 'commit-queue':
self.setProperty('bugzilla_comment_text', message)
- self.setProperty('build_finish_summary', message)
self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()])
else:
- self.build.buildFinished([message], FAILURE)
+ self.build.addStepsAfterCurrentStep([SetCommitQueueMinusFlagOnPatch()])
@defer.inlineCallbacks
def getResults(self, name):
@@ -2129,13 +2129,13 @@
message += ' ...'
self.descriptionDone = message
self.send_email_for_new_test_failures(new_failures)
+ self.setProperty('build_finish_summary', message)
if self.getProperty('buildername', '').lower() == 'commit-queue':
self.setProperty('bugzilla_comment_text', message)
- self.setProperty('build_finish_summary', message)
self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()])
else:
- self.build.buildFinished([message], FAILURE)
+ self.build.addStepsAfterCurrentStep([SetCommitQueueMinusFlagOnPatch()])
return defer.succeed(None)
def report_pre_existing_failures(self, clean_tree_failures, flaky_failures):
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (266740 => 266741)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-09-08 19:25:13 UTC (rev 266740)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-09-08 19:29:26 UTC (rev 266741)
@@ -1082,7 +1082,7 @@
self.expectOutcome(result=FAILURE, state_string='Patch 1234 does not build (failure)')
rc = self.runStep()
self.assertEqual(self.getProperty('bugzilla_comment_text'), None)
- self.assertEqual(self.getProperty('build_finish_summary'), None)
+ self.assertEqual(self.getProperty('build_finish_summary'), 'Patch 1234 does not build')
return rc
def test_patch_with_build_failure_on_commit_queue(self):
@@ -1941,7 +1941,7 @@
self.expectOutcome(result=FAILURE, state_string='Found 1 new test failure: test1 (failure)')
rc = self.runStep()
self.assertEqual(self.getProperty('bugzilla_comment_text'), None)
- self.assertEqual(self.getProperty('build_finish_summary'), None)
+ self.assertEqual(self.getProperty('build_finish_summary'), 'Found 1 new test failure: test1')
return rc
def test_consistent_failure_without_clean_tree_failures_commit_queue(self):
Modified: trunk/Tools/ChangeLog (266740 => 266741)
--- trunk/Tools/ChangeLog 2020-09-08 19:25:13 UTC (rev 266740)
+++ trunk/Tools/ChangeLog 2020-09-08 19:29:26 UTC (rev 266741)
@@ -1,5 +1,17 @@
2020-09-08 Aakash Jain <aakash_j...@apple.com>
+ EWS should set cq- flag when a patch fails to build or introduces layout-test failures
+ https://bugs.webkit.org/show_bug.cgi?id=214194
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeCompileWebKitResults.start): Set cq- on patch when patch fails to build.
+ (AnalyzeLayoutTestsResults.report_failure): Set cq- on patch when patch introduces layout-test failures.
+ * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+
+2020-09-08 Aakash Jain <aakash_j...@apple.com>
+
Use https urls instead of http in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=216276
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
