Title: [267161] trunk/Tools
- Revision
- 267161
- Author
- aakash_j...@apple.com
- Date
- 2020-09-16 14:52:51 -0700 (Wed, 16 Sep 2020)
Log Message
[ews] Improve failure summary string for AnalyzeCompileWebKitResults step
https://bugs.webkit.org/show_bug.cgi?id=216566
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (267160 => 267161)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-09-16 21:34:05 UTC (rev 267160)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-09-16 21:52:51 UTC (rev 267161)
@@ -1438,14 +1438,13 @@
compile_without_patch_result = self.getStepResult(compile_without_patch_step)
if compile_without_patch_result == FAILURE:
- self.finished(FAILURE)
message = 'Unable to build WebKit without patch, retrying build'
self.descriptionDone = message
self.send_email_for_preexisting_build_failure()
+ self.finished(FAILURE)
self.build.buildFinished([message], RETRY)
return defer.succeed(None)
- self.finished(FAILURE)
self.build.results = FAILURE
patch_id = self.getProperty('patch_id', '')
message = 'Patch {} does not build'.format(patch_id)
@@ -1452,6 +1451,7 @@
self.send_email_for_new_build_failure()
self.descriptionDone = message
+ self.finished(FAILURE)
self.setProperty('build_finish_summary', message)
if self.getProperty('buildername', '').lower() == 'commit-queue':
self.setProperty('bugzilla_comment_text', message)
Modified: trunk/Tools/ChangeLog (267160 => 267161)
--- trunk/Tools/ChangeLog 2020-09-16 21:34:05 UTC (rev 267160)
+++ trunk/Tools/ChangeLog 2020-09-16 21:52:51 UTC (rev 267161)
@@ -1,3 +1,13 @@
+2020-09-16 Aakash Jain <aakash_j...@apple.com>
+
+ [ews] Improve failure summary string for AnalyzeCompileWebKitResults step
+ https://bugs.webkit.org/show_bug.cgi?id=216566
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.
+
2020-09-16 Philippe Normand <pnorm...@igalia.com>
[Flatpak] webkit-bwrap drive-by cleanups
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
