Modified: trunk/Tools/BuildSlaveSupport/ews-build/emails.json (267491 => 267492)
--- trunk/Tools/BuildSlaveSupport/ews-build/emails.json 2020-09-23 18:45:11 UTC (rev 267491)
+++ trunk/Tools/BuildSlaveSupport/ews-build/emails.json 2020-09-23 19:07:10 UTC (rev 267492)
@@ -6,5 +6,8 @@
"BOT_WATCHERS_EMAILS": [
"webkit-ews-bot-watch...@group.apple.com"
],
+ "IGALIA_JSC_TEAM_EMAILS": [
+ "js...@igalia.com"
+ ],
"EMAIL_IDS_TO_UNSUBSCRIBE": ["pnorm...@igalia.com"]
}
Modified: trunk/Tools/BuildSlaveSupport/ews-build/send_email.py (267491 => 267492)
--- trunk/Tools/BuildSlaveSupport/ews-build/send_email.py 2020-09-23 18:45:11 UTC (rev 267491)
+++ trunk/Tools/BuildSlaveSupport/ews-build/send_email.py 2020-09-23 19:07:10 UTC (rev 267492)
@@ -80,3 +80,7 @@
def send_email_to_bot_watchers(subject, text, reference=''):
send_email(get_email_ids('BOT_WATCHERS_EMAILS'), subject, text, reference)
+
+
+def send_email_to_igalia_jsc_team(subject, text, reference=''):
+ send_email(get_email_ids('IGALIA_JSC_TEAM_EMAILS'), subject, text, reference)
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (267491 => 267492)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-09-23 18:45:11 UTC (rev 267491)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-09-23 19:07:10 UTC (rev 267492)
@@ -30,7 +30,7 @@
from twisted.internet import defer
from layout_test_failures import LayoutTestFailures
-from send_email import send_email_to_patch_author, send_email_to_bot_watchers
+from send_email import send_email_to_patch_author, send_email_to_bot_watchers, send_email_to_igalia_jsc_team
import json
import re
@@ -42,6 +42,7 @@
S3_RESULTS_URL = 'https://ews-build.s3-us-west-2.amazonaws.com/'
EWS_BUILD_URL = 'https://ews-build.webkit.org/'
EWS_URL = 'https://ews.webkit.org/'
+IGALIA_JSC_QUEUES_PATTERNS = ['armv7', 'mips', 'i386']
RESULTS_DB_URL = 'https://results.webkit.org/'
WithProperties = properties.WithProperties
Interpolate = properties.Interpolate
@@ -1548,6 +1549,8 @@
logs = logs.replace('&', '&').replace('<', '<').replace('>', '>')
email_text += u'\n\nError lines:\n\n<code>{}</code>'.format(logs)
send_email_to_bot_watchers(email_subject, email_text, 'preexisting-build-failure-{}-{}'.format(builder_name, date.today().strftime("%Y-%d-%m")))
+ if any(pattern in builder_name.lower() for pattern in IGALIA_JSC_QUEUES_PATTERNS):
+ send_email_to_igalia_jsc_team(email_subject, email_text, 'preexisting-build-failure-{}-{}'.format(builder_name, date.today().strftime("%Y-%d-%m")))
except Exception as e:
print('Error in sending email for build failure: {}'.format(e))
@@ -1811,6 +1814,8 @@
email_subject = u'Pre-existing test failure: {}'.format(test_name)
email_text = 'Test {} failed on clean tree run in {}.\n\nBuilder: {}\n\nWorker: {}\n\nHistory: {}'.format(test_name, build_url, builder_name, worker_name, history_url)
send_email_to_bot_watchers(email_subject, email_text, 'preexisting-{}'.format(test_name))
+ if any(pattern in builder_name.lower() for pattern in IGALIA_JSC_QUEUES_PATTERNS):
+ send_email_to_igalia_jsc_team(email_subject, email_text, 'preexisting-{}'.format(test_name))
except Exception as e:
print('Error in sending email for pre-existing failure: {}'.format(e))
Modified: trunk/Tools/ChangeLog (267491 => 267492)
--- trunk/Tools/ChangeLog 2020-09-23 18:45:11 UTC (rev 267491)
+++ trunk/Tools/ChangeLog 2020-09-23 19:07:10 UTC (rev 267492)
@@ -1,3 +1,16 @@
+2020-09-23 Aakash Jain <aakash_j...@apple.com>
+
+ Notify igalia team about pre-existing test failures and build failures for JSC queues
+ https://bugs.webkit.org/show_bug.cgi?id=216889
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Send email for pre-existing jsc build failures.
+ (AnalyzeJSCTestsResults.send_email_for_pre_existing_failure): Send email for pre-existing jsc test failure.
+ * BuildSlaveSupport/ews-build/send_email.py:
+ * BuildSlaveSupport/ews-build/emails.json: Added email address of igalia jsc team.
+
2020-09-23 Truitt Savell <tsav...@apple.com>
Unreviewed, reverting r267403.