Title: [267739] trunk/Tools
- Revision
- 267739
- Author
- aakash_j...@apple.com
- Date
- 2020-09-29 09:27:13 -0700 (Tue, 29 Sep 2020)
Log Message
[ews] Refactor NUM_API_FAILURES_TO_DISPLAY
https://bugs.webkit.org/show_bug.cgi?id=217086
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeAPITestsResults):
(AnalyzeAPITestsResults.analyzeResults):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (267738 => 267739)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-09-29 16:04:01 UTC (rev 267738)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-09-29 16:27:13 UTC (rev 267739)
@@ -2548,7 +2548,7 @@
name = 'analyze-api-tests-results'
description = ['analyze-api-test-results']
descriptionDone = ['analyze-api-tests-results']
- NUM_API_FAILURES_TO_DISPLAY = 10
+ NUM_FAILURES_TO_DISPLAY = 10
def start(self):
self.results = {}
@@ -2585,15 +2585,15 @@
first_run_failures = getAPITestFailures(first_run_results)
second_run_failures = getAPITestFailures(second_run_results)
clean_tree_failures = getAPITestFailures(clean_tree_results)
- clean_tree_failures_to_display = list(clean_tree_failures)[:self.NUM_API_FAILURES_TO_DISPLAY]
+ clean_tree_failures_to_display = list(clean_tree_failures)[:self.NUM_FAILURES_TO_DISPLAY]
clean_tree_failures_string = ', '.join(clean_tree_failures_to_display)
failures_with_patch = first_run_failures.intersection(second_run_failures)
flaky_failures = first_run_failures.union(second_run_failures) - first_run_failures.intersection(second_run_failures)
- flaky_failures = list(flaky_failures)[:self.NUM_API_FAILURES_TO_DISPLAY]
+ flaky_failures = list(flaky_failures)[:self.NUM_FAILURES_TO_DISPLAY]
flaky_failures_string = ', '.join(flaky_failures)
new_failures = failures_with_patch - clean_tree_failures
- new_failures_to_display = list(new_failures)[:self.NUM_API_FAILURES_TO_DISPLAY]
+ new_failures_to_display = list(new_failures)[:self.NUM_FAILURES_TO_DISPLAY]
new_failures_string = ', '.join(new_failures_to_display)
self._addToLog('stderr', '\nFailures in API Test first run: {}'.format(first_run_failures))
@@ -2607,7 +2607,7 @@
self.build.results = FAILURE
pluralSuffix = 's' if len(new_failures) > 1 else ''
message = 'Found {} new API test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
- if len(new_failures) > self.NUM_API_FAILURES_TO_DISPLAY:
+ if len(new_failures) > self.NUM_FAILURES_TO_DISPLAY:
message += ' ...'
self.descriptionDone = message
self.build.buildFinished([message], FAILURE)
@@ -2622,7 +2622,7 @@
message = 'Found {} pre-existing API test failure{}: {}'.format(len(clean_tree_failures), pluralSuffix, clean_tree_failures_string)
for clean_tree_failure in clean_tree_failures_to_display:
self.send_email_for_pre_existing_failure(clean_tree_failure)
- if len(clean_tree_failures) > self.NUM_API_FAILURES_TO_DISPLAY:
+ if len(clean_tree_failures) > self.NUM_FAILURES_TO_DISPLAY:
message += ' ...'
if flaky_failures:
message += ' Found flaky tests: {}'.format(flaky_failures_string)
Modified: trunk/Tools/ChangeLog (267738 => 267739)
--- trunk/Tools/ChangeLog 2020-09-29 16:04:01 UTC (rev 267738)
+++ trunk/Tools/ChangeLog 2020-09-29 16:27:13 UTC (rev 267739)
@@ -1,5 +1,16 @@
2020-09-29 Aakash Jain <aakash_j...@apple.com>
+ [ews] Refactor NUM_API_FAILURES_TO_DISPLAY
+ https://bugs.webkit.org/show_bug.cgi?id=217086
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeAPITestsResults):
+ (AnalyzeAPITestsResults.analyzeResults):
+
+2020-09-29 Aakash Jain <aakash_j...@apple.com>
+
Limit maximum number of webkitpy failures to display
https://bugs.webkit.org/show_bug.cgi?id=217087
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
