Title: [267888] trunk/Source/WebKit
- Revision
- 267888
- Author
- wenson_hs...@apple.com
- Date
- 2020-10-02 10:47:06 -0700 (Fri, 02 Oct 2020)
Log Message
[GPU Process] fast/canvas/canvas-createPattern-video-loading.html times out
https://bugs.webkit.org/show_bug.cgi?id=217227
Reviewed by Eric Carlson.
Even after supporting `createPattern` with video elements using the GPU process for both media and canvas
rendering, we still fail this test due to a security error that is thrown when consulting
`CanvasRenderingContext::wouldTaintOrigin`. This, in turn, is due to the fact that we never attempt to update
cached `wouldTaintDocumentSecurityOrigin` state on `MediaPlayerPrivateRemote`, so it remains `true`.
This change will be covered by fast/canvas/canvas-createPattern-video-loading.html, which should now fail with a
text diff instead of timing out due to lack of support for creating a `CanvasPattern` out of a video element.
* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::updateCachedState):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (267887 => 267888)
--- trunk/Source/WebKit/ChangeLog 2020-10-02 17:26:15 UTC (rev 267887)
+++ trunk/Source/WebKit/ChangeLog 2020-10-02 17:47:06 UTC (rev 267888)
@@ -1,3 +1,21 @@
+2020-10-02 Wenson Hsieh <wenson_hs...@apple.com>
+
+ [GPU Process] fast/canvas/canvas-createPattern-video-loading.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=217227
+
+ Reviewed by Eric Carlson.
+
+ Even after supporting `createPattern` with video elements using the GPU process for both media and canvas
+ rendering, we still fail this test due to a security error that is thrown when consulting
+ `CanvasRenderingContext::wouldTaintOrigin`. This, in turn, is due to the fact that we never attempt to update
+ cached `wouldTaintDocumentSecurityOrigin` state on `MediaPlayerPrivateRemote`, so it remains `true`.
+
+ This change will be covered by fast/canvas/canvas-createPattern-video-loading.html, which should now fail with a
+ text diff instead of timing out due to lack of support for creating a `CanvasPattern` out of a video element.
+
+ * WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
+ (WebKit::MediaPlayerPrivateRemote::updateCachedState):
+
2020-10-02 Sam Weinig <wei...@apple.com>
Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
Modified: trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp (267887 => 267888)
--- trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2020-10-02 17:26:15 UTC (rev 267887)
+++ trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2020-10-02 17:47:06 UTC (rev 267888)
@@ -409,6 +409,7 @@
m_cachedState.wirelessVideoPlaybackDisabled = state.wirelessVideoPlaybackDisabled;
m_cachedState.hasSingleSecurityOrigin = state.hasSingleSecurityOrigin;
m_cachedState.didPassCORSAccessCheck = state.didPassCORSAccessCheck;
+ m_cachedState.wouldTaintDocumentSecurityOrigin = state.wouldTaintDocumentSecurityOrigin;
if (state.bufferedRanges.length())
m_cachedBufferedTimeRanges = makeUnique<PlatformTimeRanges>(state.bufferedRanges);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
