Title: [267949] trunk
Revision
267949
Author
commit-qu...@webkit.org
Date
2020-10-04 14:09:14 -0700 (Sun, 04 Oct 2020)

Log Message

Submission failure with "make: *** No rule to make target `installsrc'. Stop"
https://bugs.webkit.org/show_bug.cgi?id=214696
<rdar://problem/62268104>

Patch by Ryan Hostetler <rh...@apple.com> on 2020-10-04
Reviewed by Darin Adler.

.:

Add installsrc phase to support xbs submitproject for WebKit repository.
This change allows internal tools to submit and build in a single step.

* Makefile:
* Makefile.shared:
* Source/Makefile:

Source/ThirdParty:

Add installsrc phase to support xbs submitproject for WebKit repository.
This change allows internal tools to submit and build in a single step.

* Makefile:

Tools:

Add support for XBS single base project build for WebKit repository.
This change allows internal tools to submit and build from the repository root in a single step.

* Makefile:
Tools does not need to be submitted, so we stub out the installsrc phase.

WebKitLibraries:

Add support for XBS single base project build for WebKit repository.
This change allows internal tools to submit and build from the repository root in a single step.

* Makefile:
WebKitLibraries do not need to be submitted, so we stub out the installsrc phase.

Modified Paths

Diff

Modified: trunk/ChangeLog (267948 => 267949)


--- trunk/ChangeLog	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/ChangeLog	2020-10-04 21:09:14 UTC (rev 267949)
@@ -1,3 +1,18 @@
+2020-10-04  Ryan Hostetler  <rh...@apple.com>
+
+        Submission failure with "make: *** No rule to make target `installsrc'. Stop"
+        https://bugs.webkit.org/show_bug.cgi?id=214696
+        <rdar://problem/62268104>
+
+        Reviewed by Darin Adler.
+
+        Add installsrc phase to support xbs submitproject for WebKit repository.
+        This change allows internal tools to submit and build in a single step.
+
+        * Makefile:
+        * Makefile.shared:
+        * Source/Makefile:
+
 2020-10-02  Keith Rollin  <krol...@apple.com>
 
         Seeing "usage: basename string [suffix]" spam when using make to build

Modified: trunk/Makefile (267948 => 267949)


--- trunk/Makefile	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/Makefile	2020-10-04 21:09:14 UTC (rev 267949)
@@ -28,3 +28,6 @@
 
 clean:
 	@$(build_target_for_each_module)
+
+installsrc:
+	$(build_target_for_each_module)

Modified: trunk/Makefile.shared (267948 => 267949)


--- trunk/Makefile.shared	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/Makefile.shared	2020-10-04 21:09:14 UTC (rev 267949)
@@ -139,4 +139,7 @@
 clean:
 	@$(call invoke_xcode,,-alltargets clean)
 
+installsrc:
+	@$(call invoke_xcode,,-alltargets installsrc SRCROOT="$(SRCROOT)$(PATH_FROM_ROOT)")
+
 force: ;

Modified: trunk/Source/Makefile (267948 => 267949)


--- trunk/Source/Makefile	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/Source/Makefile	2020-10-04 21:09:14 UTC (rev 267949)
@@ -38,3 +38,6 @@
 
 clean:
 	@$(build_target_for_each_module)
+
+installsrc:
+	@$(build_target_for_each_module)

Modified: trunk/Source/ThirdParty/ChangeLog (267948 => 267949)


--- trunk/Source/ThirdParty/ChangeLog	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/Source/ThirdParty/ChangeLog	2020-10-04 21:09:14 UTC (rev 267949)
@@ -1,3 +1,16 @@
+2020-10-04  Ryan Hostetler  <rh...@apple.com>
+
+        Submission failure with "make: *** No rule to make target `installsrc'. Stop"
+        https://bugs.webkit.org/show_bug.cgi?id=214696
+        <rdar://problem/62268104>
+
+        Reviewed by Darin Adler.
+
+        Add installsrc phase to support xbs submitproject for WebKit repository.
+        This change allows internal tools to submit and build in a single step.
+
+        * Makefile:
+
 2020-09-22  Keith Rollin  <krol...@apple.com>
 
         Unify debug and release target aliases

Modified: trunk/Source/ThirdParty/Makefile (267948 => 267949)


--- trunk/Source/ThirdParty/Makefile	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/Source/ThirdParty/Makefile	2020-10-04 21:09:14 UTC (rev 267949)
@@ -52,3 +52,6 @@
 
 clean:
 	@$(build_target_for_each_module)
+
+installsrc:
+	@$(build_target_for_each_module)

Modified: trunk/Tools/ChangeLog (267948 => 267949)


--- trunk/Tools/ChangeLog	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/Tools/ChangeLog	2020-10-04 21:09:14 UTC (rev 267949)
@@ -1,3 +1,17 @@
+2020-10-04  Ryan Hostetler  <rh...@apple.com>
+
+        Submission failure with "make: *** No rule to make target `installsrc'. Stop"
+        https://bugs.webkit.org/show_bug.cgi?id=214696
+        <rdar://problem/62268104>
+
+        Reviewed by Darin Adler.
+
+        Add support for XBS single base project build for WebKit repository.
+        This change allows internal tools to submit and build from the repository root in a single step.
+
+        * Makefile:
+        Tools does not need to be submitted, so we stub out the installsrc phase.
+
 2020-10-03  Alex Christensen  <achristen...@webkit.org>
 
         Add extra slash after empty host copied from base URL if path is also empty

Modified: trunk/Tools/Makefile (267948 => 267949)


--- trunk/Tools/Makefile	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/Tools/Makefile	2020-10-04 21:09:14 UTC (rev 267949)
@@ -48,3 +48,6 @@
 
 clean:
 	@$(build_target_for_each_module)
+
+installsrc:
+	@true

Modified: trunk/WebKitLibraries/ChangeLog (267948 => 267949)


--- trunk/WebKitLibraries/ChangeLog	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/WebKitLibraries/ChangeLog	2020-10-04 21:09:14 UTC (rev 267949)
@@ -1,3 +1,17 @@
+2020-10-04  Ryan Hostetler  <rh...@apple.com>
+
+        Submission failure with "make: *** No rule to make target `installsrc'. Stop"
+        https://bugs.webkit.org/show_bug.cgi?id=214696
+        <rdar://problem/62268104>
+
+        Reviewed by Darin Adler.
+
+        Add support for XBS single base project build for WebKit repository.
+        This change allows internal tools to submit and build from the repository root in a single step.
+
+        * Makefile:
+        WebKitLibraries do not need to be submitted, so we stub out the installsrc phase.
+
 2020-07-26  Wenson Hsieh  <wenson_hs...@apple.com>
 
         REGRESSION (r264690): [ iOS wk2 ] editing/selection/shift-click-includes-existing-selection.html is a flaky failure

Modified: trunk/WebKitLibraries/Makefile (267948 => 267949)


--- trunk/WebKitLibraries/Makefile	2020-10-04 17:06:19 UTC (rev 267948)
+++ trunk/WebKitLibraries/Makefile	2020-10-04 21:09:14 UTC (rev 267949)
@@ -36,3 +36,6 @@
 
 clean:
 	@$(MAKE) cleanlibs
+
+installsrc:
+	@true
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to