Title: [267998] trunk/Source/WebInspectorUI
- Revision
- 267998
- Author
- drou...@apple.com
- Date
- 2020-10-05 13:03:05 -0700 (Mon, 05 Oct 2020)
Log Message
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'breakpoint.disabled = true')
https://bugs.webkit.org/show_bug.cgi?id=217241
Reviewed by Brian Burg.
* UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.removeBreakpointForEventListener):
It's possible for there to not be a breakpoint for a given event listener.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (267997 => 267998)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-10-05 19:57:42 UTC (rev 267997)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-10-05 20:03:05 UTC (rev 267998)
@@ -1,5 +1,16 @@
2020-10-05 Devin Rousso <drou...@apple.com>
+ Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'breakpoint.disabled = true')
+ https://bugs.webkit.org/show_bug.cgi?id=217241
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Controllers/DOMManager.js:
+ (WI.DOMManager.prototype.removeBreakpointForEventListener):
+ It's possible for there to not be a breakpoint for a given event listener.
+
+2020-10-05 Devin Rousso <drou...@apple.com>
+
Web Inspector: Sources: add a + to the Local Overrides section
https://bugs.webkit.org/show_bug.cgi?id=217235
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js (267997 => 267998)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js 2020-10-05 19:57:42 UTC (rev 267997)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js 2020-10-05 20:03:05 UTC (rev 267998)
@@ -694,13 +694,9 @@
removeBreakpointForEventListener(eventListener)
{
let breakpoint = this._breakpointsForEventListeners.take(eventListener.eventListenerId);
- console.assert(breakpoint);
+ if (!breakpoint)
+ return;
- for (let target of WI.targets) {
- if (target.hasDomain("DOM"))
- target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId);
- }
-
// Disable the breakpoint first, so removing actions doesn't re-add the breakpoint.
breakpoint.disabled = true;
breakpoint.clearActions();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
