Log Message
Release assert in ~Node due to render element of pseudo element not getting removed in time https://bugs.webkit.org/show_bug.cgi?id=217996
Patch by Julian Gonzalez <julian_a_gonza...@apple.com> on 2020-10-20 Reviewed by Ryosuke Niwa. When attaching a shadow root to an element, remember to tear down renderers not only if one exists on the element, but also if it uses display: contents. * dom/Element.cpp: (WebCore::Element::addShadowRoot):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (268781 => 268782)
--- trunk/Source/WebCore/ChangeLog 2020-10-21 02:25:13 UTC (rev 268781)
+++ trunk/Source/WebCore/ChangeLog 2020-10-21 03:33:03 UTC (rev 268782)
@@ -1,3 +1,16 @@
+2020-10-20 Julian Gonzalez <julian_a_gonza...@apple.com>
+
+ Release assert in ~Node due to render element of pseudo element not getting removed in time
+ https://bugs.webkit.org/show_bug.cgi?id=217996
+
+ Reviewed by Ryosuke Niwa.
+
+ When attaching a shadow root to an element, remember to tear down renderers not only if
+ one exists on the element, but also if it uses display: contents.
+
+ * dom/Element.cpp:
+ (WebCore::Element::addShadowRoot):
+
2020-10-20 Sihui Liu <sihui_...@apple.com>
Add stubs for SpeechRecognition
Modified: trunk/Source/WebCore/dom/Element.cpp (268781 => 268782)
--- trunk/Source/WebCore/dom/Element.cpp 2020-10-21 02:25:13 UTC (rev 268781)
+++ trunk/Source/WebCore/dom/Element.cpp 2020-10-21 03:33:03 UTC (rev 268782)
@@ -2300,7 +2300,7 @@
{
WidgetHierarchyUpdatesSuspensionScope suspendWidgetHierarchyUpdates;
ScriptDisallowedScope::InMainThread scriptDisallowedScope;
- if (renderer())
+ if (renderer() || hasDisplayContents())
RenderTreeUpdater::tearDownRenderers(*this);
ensureElementRareData().setShadowRoot(WTFMove(newShadowRoot));
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
