Title: [268817] trunk/Source/WebCore
- Revision
- 268817
- Author
- za...@apple.com
- Date
- 2020-10-21 12:29:59 -0700 (Wed, 21 Oct 2020)
Log Message
[LFC][Integration] Remove redundant vertical position snapping in the iterator interface
https://bugs.webkit.org/show_bug.cgi?id=218039
Reviewed by Antti Koivisto.
Snapping is done during display content construction.
* layout/integration/LayoutIntegrationRunIteratorModernPath.h:
(WebCore::LayoutIntegration::RunIteratorModernPath::rect const):
(WebCore::LayoutIntegration::verticallyRoundedRect): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (268816 => 268817)
--- trunk/Source/WebCore/ChangeLog 2020-10-21 19:21:55 UTC (rev 268816)
+++ trunk/Source/WebCore/ChangeLog 2020-10-21 19:29:59 UTC (rev 268817)
@@ -1,3 +1,16 @@
+2020-10-21 Zalan Bujtas <za...@apple.com>
+
+ [LFC][Integration] Remove redundant vertical position snapping in the iterator interface
+ https://bugs.webkit.org/show_bug.cgi?id=218039
+
+ Reviewed by Antti Koivisto.
+
+ Snapping is done during display content construction.
+
+ * layout/integration/LayoutIntegrationRunIteratorModernPath.h:
+ (WebCore::LayoutIntegration::RunIteratorModernPath::rect const):
+ (WebCore::LayoutIntegration::verticallyRoundedRect): Deleted.
+
2020-10-21 Peng Liu <peng.l...@apple.com>
A video element may fail to enter picture-in-picture from fullscreen
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h (268816 => 268817)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h 2020-10-21 19:21:55 UTC (rev 268816)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h 2020-10-21 19:29:59 UTC (rev 268817)
@@ -34,11 +34,6 @@
namespace LayoutIntegration {
-inline FloatRect verticallyRoundedRect(const FloatRect& rect)
-{
- return { FloatPoint(rect.x(), roundf(rect.y())), rect.size() };
-}
-
class RunIteratorModernPath {
public:
RunIteratorModernPath(const InlineContent& inlineContent)
@@ -54,7 +49,7 @@
bool isText() const { return !!run().textContent(); }
- FloatRect rect() const { return verticallyRoundedRect(run().rect()); }
+ FloatRect rect() const { return run().rect(); }
bool isHorizontal() const { return true; }
bool dirOverride() const { return false; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
