Diff
Modified: trunk/Source/WebCore/ChangeLog (269703 => 269704)
--- trunk/Source/WebCore/ChangeLog 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebCore/ChangeLog 2020-11-11 23:37:04 UTC (rev 269704)
@@ -1,3 +1,13 @@
+2020-11-11 Sam Weinig <wei...@apple.com>
+
+ Remove unused ExperimentalNotificationsEnabled setting
+ https://bugs.webkit.org/show_bug.cgi?id=218813
+
+ Reviewed by Tim Horton.
+
+ * page/Settings.yaml:
+ Remove ExperimentalNotificationsEnabled. It was unused.
+
2020-11-11 Brian Burg <bb...@apple.com>
[Cocoa] Inspector Extensions: Add _WKInspectorExtension and related plumbing
Modified: trunk/Source/WebCore/page/Settings.yaml (269703 => 269704)
--- trunk/Source/WebCore/page/Settings.yaml 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebCore/page/Settings.yaml 2020-11-11 23:37:04 UTC (rev 269704)
@@ -187,12 +187,6 @@
WebCore:
default: true
-ExperimentalNotificationsEnabled:
- type: bool
- defaultValue:
- WebCore:
- default: false
-
FixedBackgroundsPaintRelativeToDocument:
type: bool
defaultValue:
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (269703 => 269704)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-11-11 23:37:04 UTC (rev 269704)
@@ -1,3 +1,20 @@
+2020-11-11 Sam Weinig <wei...@apple.com>
+
+ Remove unused ExperimentalNotificationsEnabled setting
+ https://bugs.webkit.org/show_bug.cgi?id=218813
+
+ Reviewed by Tim Horton.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences setExperimentalNotificationsEnabled:]):
+ (-[WebPreferences experimentalNotificationsEnabled]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+ Obsolete ExperimentalNotificationsEnabled preference as it does nothing.
+
2020-11-10 Commit Queue <commit-qu...@webkit.org>
Unreviewed, reverting r269660.
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (269703 => 269704)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-11-11 23:37:04 UTC (rev 269704)
@@ -62,7 +62,6 @@
#define WebKitPluginsEnabledPreferenceKey @"WebKitPluginsEnabled"
#define WebKitDatabasesEnabledPreferenceKey @"WebKitDatabasesEnabledPreferenceKey"
#define WebKitLocalStorageEnabledPreferenceKey @"WebKitLocalStorageEnabledPreferenceKey"
-#define WebKitExperimentalNotificationsEnabledPreferenceKey @"WebKitExperimentalNotificationsEnabledPreferenceKey"
#define WebKitAllowAnimatedImagesPreferenceKey @"WebKitAllowAnimatedImagesPreferenceKey"
#define WebKitAllowAnimatedImageLoopingPreferenceKey @"WebKitAllowAnimatedImageLoopingPreferenceKey"
#define WebKitDisplayImagesKey @"WebKitDisplayImagesKey"
@@ -299,3 +298,4 @@
#define WebKitIsSecureContextAttributeEnabledPreferenceKey @"WebKitIsSecureContextAttributeEnabled"
#define WebKitCSSShadowPartsEnabledPreferenceKey @"WebKitCSSShadowPartsEnabled"
#define WebKitSubpixelCSSOMElementMetricsEnabledPreferenceKey @"WebKitSubpixelCSSOMElementMetricsEnabled"
+#define WebKitExperimentalNotificationsEnabledPreferenceKey @"WebKitExperimentalNotificationsEnabledPreferenceKey"
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (269703 => 269704)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-11-11 23:37:04 UTC (rev 269704)
@@ -395,7 +395,6 @@
@NO, WebKitUserStyleSheetEnabledPreferenceKey,
@"", WebKitUserStyleSheetLocationPreferenceKey,
@NO, WebKitShrinksStandaloneImagesToFitPreferenceKey,
- @NO, WebKitExperimentalNotificationsEnabledPreferenceKey,
@YES, WebKitAllowAnimatedImagesPreferenceKey,
@YES, WebKitAllowAnimatedImageLoopingPreferenceKey,
@"1800", WebKitBackForwardCacheExpirationIntervalKey,
@@ -1579,16 +1578,6 @@
[self _setBoolValue:localStorageEnabled forKey:WebKitLocalStorageEnabledPreferenceKey];
}
-- (BOOL)experimentalNotificationsEnabled
-{
- return [self _boolValueForKey:WebKitExperimentalNotificationsEnabledPreferenceKey];
-}
-
-- (void)setExperimentalNotificationsEnabled:(BOOL)experimentalNotificationsEnabled
-{
- [self _setBoolValue:experimentalNotificationsEnabled forKey:WebKitExperimentalNotificationsEnabledPreferenceKey];
-}
-
+ (WebPreferences *)_getInstanceForIdentifier:(NSString *)ident
{
LOG(Encoding, "requesting for %@\n", ident);
@@ -3504,4 +3493,13 @@
return NO;
}
+- (void)setExperimentalNotificationsEnabled:(BOOL)enabled
+{
+}
+
+- (BOOL)experimentalNotificationsEnabled
+{
+ return NO;
+}
+
@end
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (269703 => 269704)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-11-11 23:37:04 UTC (rev 269704)
@@ -123,7 +123,6 @@
@property (nonatomic) BOOL zoomsTextOnly;
@property (nonatomic) BOOL _javascript_CanAccessClipboard;
@property (nonatomic, getter=isXSSAuditorEnabled) BOOL XSSAuditorEnabled;
-@property (nonatomic) BOOL experimentalNotificationsEnabled;
@property (nonatomic, getter=isFrameFlatteningEnabled) BOOL frameFlatteningEnabled;
@property (nonatomic) WebKitFrameFlattening frameFlattening;
@property (nonatomic) BOOL asyncFrameScrollingEnabled;
@@ -369,6 +368,7 @@
@property (nonatomic, getter=isVideoPluginProxyEnabled) BOOL videoPluginProxyEnabled;
@property (nonatomic, getter=isHixie76WebSocketProtocolEnabled) BOOL hixie76WebSocketProtocolEnabled;
@property (nonatomic) BOOL accelerated2dCanvasEnabled;
+@property (nonatomic) BOOL experimentalNotificationsEnabled;
- (void)setDiskImageCacheEnabled:(BOOL)enabled;
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (269703 => 269704)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-11-11 23:37:04 UTC (rev 269704)
@@ -3088,7 +3088,6 @@
settings.setNeedsKeyboardEventDisambiguationQuirks([self _needsKeyboardEventDisambiguationQuirks]);
settings.setEnforceCSSMIMETypeInNoQuirksMode(!_CFAppVersionCheckLessThan(CFSTR("com.apple.iWeb"), -1, 2.1));
settings.setNeedsIsLoadingInAPISenseQuirk([self _needsIsLoadingInAPISenseQuirk]);
- settings.setExperimentalNotificationsEnabled([preferences experimentalNotificationsEnabled]);
#endif
#if PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (269703 => 269704)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2020-11-11 23:37:04 UTC (rev 269704)
@@ -1,3 +1,17 @@
+2020-11-11 Sam Weinig <wei...@apple.com>
+
+ Remove unused ExperimentalNotificationsEnabled setting
+ https://bugs.webkit.org/show_bug.cgi?id=218813
+
+ Reviewed by Tim Horton.
+
+ * WebPreferences.cpp:
+ (WebPreferences::setExperimentalNotificationsEnabled):
+ (WebPreferences::experimentalNotificationsEnabled):
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+ Obsolete ExperimentalNotificationsEnabled preference as it does nothing.
+
2020-11-09 Chris Dumez <cdu...@apple.com>
Unexpose obsolete HTMLAppletElement interface
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (269703 => 269704)
--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2020-11-11 23:37:04 UTC (rev 269704)
@@ -1686,9 +1686,8 @@
return S_OK;
}
-HRESULT WebPreferences::setExperimentalNotificationsEnabled(BOOL enabled)
+HRESULT WebPreferences::setExperimentalNotificationsEnabled(BOOL)
{
- setBoolValue(WebKitExperimentalNotificationsEnabledPreferenceKey, enabled);
return S_OK;
}
@@ -1696,7 +1695,7 @@
{
if (!enabled)
return E_POINTER;
- *enabled = boolValueForKey(WebKitExperimentalNotificationsEnabledPreferenceKey);
+ *enabled = true;
return S_OK;
}
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (269703 => 269704)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2020-11-11 23:37:04 UTC (rev 269704)
@@ -5458,11 +5458,6 @@
return hr;
settings.setLocalStorageEnabled(enabled);
- hr = prefsPrivate->experimentalNotificationsEnabled(&enabled);
- if (FAILED(hr))
- return hr;
- settings.setExperimentalNotificationsEnabled(enabled);
-
hr = prefsPrivate->isWebSecurityEnabled(&enabled);
if (FAILED(hr))
return hr;
Modified: trunk/Tools/ChangeLog (269703 => 269704)
--- trunk/Tools/ChangeLog 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Tools/ChangeLog 2020-11-11 23:37:04 UTC (rev 269704)
@@ -1,3 +1,16 @@
+2020-11-11 Sam Weinig <wei...@apple.com>
+
+ Remove unused ExperimentalNotificationsEnabled setting
+ https://bugs.webkit.org/show_bug.cgi?id=218813
+
+ Reviewed by Tim Horton.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (resetWebPreferencesToConsistentValues):
+ Stop setting ExperimentalNotificationsEnabled to false. It does nothing.
+
2020-11-11 Chris Dumez <cdu...@apple.com>
Terminate WebProcesses if GPUProcess crashes more than twice in 30 seconds
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (269703 => 269704)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2020-11-11 23:37:04 UTC (rev 269704)
@@ -856,7 +856,6 @@
[preferences setDownloadAttributeEnabled:YES];
[preferences setEditableLinkBehavior:WebKitEditableLinkOnlyLiveWithShiftKey];
[preferences setEncryptedMediaAPIEnabled:YES];
- [preferences setExperimentalNotificationsEnabled:NO];
[preferences setFantasyFontFamily:@"Papyrus"];
[preferences setFixedFontFamily:@"Courier"];
[preferences setFrameFlattening:WebKitFrameFlatteningDisabled];
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (269703 => 269704)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2020-11-11 22:49:31 UTC (rev 269703)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2020-11-11 23:37:04 UTC (rev 269704)
@@ -883,7 +883,6 @@
preferences->setShouldPrintBackgrounds(TRUE);
preferences->setCacheModel(WebCacheModelDocumentBrowser);
prefsPrivate->setXSSAuditorEnabled(FALSE);
- prefsPrivate->setExperimentalNotificationsEnabled(FALSE);
preferences->setPlugInsEnabled(TRUE);
preferences->setTextAreasAreResizable(TRUE);
preferences->setUsesPageCache(FALSE);
