Title: [270022] trunk/Source/WebKit
- Revision
- 270022
- Author
- commit-qu...@webkit.org
- Date
- 2020-11-19 05:55:40 -0800 (Thu, 19 Nov 2020)
Log Message
[WPE] Prevent elements getting stuck in a pressed state when scrolling on a touchscreen
https://bugs.webkit.org/show_bug.cgi?id=218903
Patch by Joshua Watt <jpew.hac...@gmail.com> on 2020-11-19
Reviewed by Adrian Perez de Castro.
Stops the scroll gesture controller from eating touch up events and
preventing them from propagating to the page when the controller is
handling a scroll event. If the scroll logic prevents the events from
propagating to the page, elements on the page (e.g. buttons) can get
stuck in a pressed state when the user lifts their finger.
* UIProcess/API/wpe/ScrollGestureController.cpp:
(WebKit::ScrollGestureController::handleEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (270021 => 270022)
--- trunk/Source/WebKit/ChangeLog 2020-11-19 12:59:21 UTC (rev 270021)
+++ trunk/Source/WebKit/ChangeLog 2020-11-19 13:55:40 UTC (rev 270022)
@@ -1,3 +1,19 @@
+2020-11-19 Joshua Watt <jpew.hac...@gmail.com>
+
+ [WPE] Prevent elements getting stuck in a pressed state when scrolling on a touchscreen
+ https://bugs.webkit.org/show_bug.cgi?id=218903
+
+ Reviewed by Adrian Perez de Castro.
+
+ Stops the scroll gesture controller from eating touch up events and
+ preventing them from propagating to the page when the controller is
+ handling a scroll event. If the scroll logic prevents the events from
+ propagating to the page, elements on the page (e.g. buttons) can get
+ stuck in a pressed state when the user lifts their finger.
+
+ * UIProcess/API/wpe/ScrollGestureController.cpp:
+ (WebKit::ScrollGestureController::handleEvent):
+
2020-11-19 Carlos Garcia Campos <cgar...@igalia.com>
Protect WebSocketChannel before calling client methods
Modified: trunk/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp (270021 => 270022)
--- trunk/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp 2020-11-19 12:59:21 UTC (rev 270021)
+++ trunk/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp 2020-11-19 13:55:40 UTC (rev 270022)
@@ -118,7 +118,6 @@
#endif
m_offset.x = m_offset.y = 0;
m_phase = WebWheelEvent::Phase::PhaseEnded;
- return true;
}
return false;
default:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
