Title: [270291] trunk/Source/_javascript_Core
- Revision
- 270291
- Author
- lmo...@igalia.com
- Date
- 2020-12-01 01:44:06 -0800 (Tue, 01 Dec 2020)
Log Message
[JSC] Make Bytecodes generator command also depend on wasm.json
https://bugs.webkit.org/show_bug.cgi?id=219383
Reviewed by Adrian Perez de Castro.
r270265 added some new operations to wasm.json but its change did not
trigger the bytecodes generator command, causing the build to fail in
some platforms (in fact, it was caught by GTK and WPE EWS bots).
* CMakeLists.txt: Add wasm.json as dependency to the bytecodes.h generator
command.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (270290 => 270291)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2020-12-01 09:43:00 UTC (rev 270290)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2020-12-01 09:44:06 UTC (rev 270291)
@@ -238,7 +238,7 @@
add_custom_command(
OUTPUT ${_javascript_Core_DERIVED_SOURCES_DIR}/Bytecodes.h ${_javascript_Core_DERIVED_SOURCES_DIR}/InitBytecodes.asm ${_javascript_Core_DERIVED_SOURCES_DIR}/BytecodeStructs.h ${_javascript_Core_DERIVED_SOURCES_DIR}/BytecodeIndices.h ${_javascript_Core_DERIVED_SOURCES_DIR}/WasmLLIntGeneratorInlines.h ${_javascript_Core_DERIVED_SOURCES_DIR}/InitWasm.asm ${_javascript_Core_DERIVED_SOURCES_DIR}/BytecodeDumperGenerated.cpp
MAIN_DEPENDENCY ${_javascript_CORE_DIR}/generator/main.rb
- DEPENDS ${GENERATOR} bytecode/BytecodeList.rb
+ DEPENDS ${GENERATOR} bytecode/BytecodeList.rb ${_javascript_CORE_DIR}/wasm/wasm.json
COMMAND ${RUBY_EXECUTABLE} ${_javascript_CORE_DIR}/generator/main.rb --bytecodes_h ${_javascript_Core_DERIVED_SOURCES_DIR}/Bytecodes.h --init_bytecodes_asm ${_javascript_Core_DERIVED_SOURCES_DIR}/InitBytecodes.asm --bytecode_structs_h ${_javascript_Core_DERIVED_SOURCES_DIR}/BytecodeStructs.h --bytecode_indices_h ${_javascript_Core_DERIVED_SOURCES_DIR}/BytecodeIndices.h ${_javascript_CORE_DIR}/bytecode/BytecodeList.rb --wasm_json ${_javascript_CORE_DIR}/wasm/wasm.json --wasm_llint_generator_h ${_javascript_Core_DERIVED_SOURCES_DIR}/WasmLLIntGeneratorInlines.h --init_wasm_llint ${_javascript_Core_DERIVED_SOURCES_DIR}/InitWasm.asm --bytecode_dumper ${_javascript_Core_DERIVED_SOURCES_DIR}/BytecodeDumperGenerated.cpp
VERBATIM)
add_custom_target(Bytecodes DEPENDS "${_javascript_Core_DERIVED_SOURCES_DIR}/Bytecodes.h")
Modified: trunk/Source/_javascript_Core/ChangeLog (270290 => 270291)
--- trunk/Source/_javascript_Core/ChangeLog 2020-12-01 09:43:00 UTC (rev 270290)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-12-01 09:44:06 UTC (rev 270291)
@@ -1,3 +1,17 @@
+2020-12-01 Lauro Moura <lmo...@igalia.com>
+
+ [JSC] Make Bytecodes generator command also depend on wasm.json
+ https://bugs.webkit.org/show_bug.cgi?id=219383
+
+ Reviewed by Adrian Perez de Castro.
+
+ r270265 added some new operations to wasm.json but its change did not
+ trigger the bytecodes generator command, causing the build to fail in
+ some platforms (in fact, it was caught by GTK and WPE EWS bots).
+
+ * CMakeLists.txt: Add wasm.json as dependency to the bytecodes.h generator
+ command.
+
2020-11-30 Yusuke Suzuki <ysuz...@apple.com>
Making module entry promise-like by setting "then"
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
