Title: [105286] trunk/Source/WebCore
- Revision
- 105286
- Author
- ser...@webkit.org
- Date
- 2012-01-18 09:40:46 -0800 (Wed, 18 Jan 2012)
Log Message
[GTK] [regression] A couple of tests failing after r105253
https://bugs.webkit.org/show_bug.cgi?id=76549
Reviewed by Gustavo Noronha Silva.
Fixes a regression added by r105253. The method that
RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn()
instead of popsMenuByArrowKeys().
No new tests as it's already covered by
fast/forms/select-popup-pagekeys.html and
fast/forms/select/menulist-onchange-fired-with-key-up-down.html
that started to fail after the revision mentioned above.
* platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (105285 => 105286)
--- trunk/Source/WebCore/ChangeLog 2012-01-18 17:35:27 UTC (rev 105285)
+++ trunk/Source/WebCore/ChangeLog 2012-01-18 17:40:46 UTC (rev 105286)
@@ -1,3 +1,22 @@
+2012-01-18 Sergio Villar Senin <svil...@igalia.com>
+
+ [GTK] [regression] A couple of tests failing after r105253
+ https://bugs.webkit.org/show_bug.cgi?id=76549
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Fixes a regression added by r105253. The method that
+ RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn()
+ instead of popsMenuByArrowKeys().
+
+ No new tests as it's already covered by
+ fast/forms/select-popup-pagekeys.html and
+ fast/forms/select/menulist-onchange-fired-with-key-up-down.html
+ that started to fail after the revision mentioned above.
+
+ * platform/gtk/RenderThemeGtk.h:
+ (WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn):
+
2012-01-18 Andrey Kosyakov <ca...@chromium.org>
Web Inspector: omit compression field in HAR entries for resources coming from cache
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h (105285 => 105286)
--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h 2012-01-18 17:35:27 UTC (rev 105285)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h 2012-01-18 17:40:46 UTC (rev 105286)
@@ -82,7 +82,7 @@
virtual void systemFont(int propId, FontDescription&) const;
virtual Color systemColor(int cssValueId) const;
- virtual bool popsMenuByArrowKeys() const OVERRIDE { return true; }
+ virtual bool popsMenuBySpaceOrReturn() const OVERRIDE { return true; }
#if ENABLE(VIDEO)
virtual String extraMediaControlsStyleSheet();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
