Title: [271833] branches/safari-611-branch/Source/WebInspectorUI
- Revision
- 271833
- Author
- alanc...@apple.com
- Date
- 2021-01-25 14:11:49 -0800 (Mon, 25 Jan 2021)
Log Message
Cherry-pick r271410. rdar://problem/73478423
Web Inspector: Remove experimental setting and enable Font details sidebar
https://bugs.webkit.org/show_bug.cgi?id=220438
Reviewed by Devin Rousso.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Setting.js:
* UserInterface/Views/ElementsTabContentView.js:
(WI.ElementsTabContentView):
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611-branch/Source/WebInspectorUI/ChangeLog (271832 => 271833)
--- branches/safari-611-branch/Source/WebInspectorUI/ChangeLog 2021-01-25 22:11:46 UTC (rev 271832)
+++ branches/safari-611-branch/Source/WebInspectorUI/ChangeLog 2021-01-25 22:11:49 UTC (rev 271833)
@@ -1,3 +1,35 @@
+2021-01-25 Alan Coon <alanc...@apple.com>
+
+ Cherry-pick r271410. rdar://problem/73478423
+
+ Web Inspector: Remove experimental setting and enable Font details sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=220438
+
+ Reviewed by Devin Rousso.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/ElementsTabContentView.js:
+ (WI.ElementsTabContentView):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-12 Patrick Angle <pan...@apple.com>
+
+ Web Inspector: Remove experimental setting and enable Font details sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=220438
+
+ Reviewed by Devin Rousso.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/ElementsTabContentView.js:
+ (WI.ElementsTabContentView):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
2021-01-08 Patrick Angle <pan...@apple.com>
Web Inspector: Font Details sidebar - Improve visibility of values by emphasizing them/de-emphasizing range information
Modified: branches/safari-611-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (271832 => 271833)
--- branches/safari-611-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2021-01-25 22:11:46 UTC (rev 271832)
+++ branches/safari-611-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2021-01-25 22:11:49 UTC (rev 271833)
@@ -547,8 +547,6 @@
localizedStrings["Elements"] = "Elements";
/* Name of Elements Tab */
localizedStrings["Elements Tab Name"] = "Elements";
-/* Category label for experimental settings pertaining to the Elements tab */
-localizedStrings["Elements Tab: @ Experimental Settings"] = "Elements Tab:";
localizedStrings["Emulate User Gesture"] = "Emulate User Gesture";
localizedStrings["Enable Audit"] = "Enable Audit";
localizedStrings["Enable Breakpoint"] = "Enable Breakpoint";
@@ -1291,7 +1289,6 @@
localizedStrings["Show Console"] = "Show Console";
localizedStrings["Show Console tab"] = "Show Console tab";
localizedStrings["Show Elements"] = "Show Elements";
-localizedStrings["Show Font details sidebar panel"] = "Show Font details sidebar panel";
localizedStrings["Show Path"] = "Show Path";
localizedStrings["Show Remaining (%d)"] = "Show Remaining (%d)";
localizedStrings["Show Scope Chain on pause"] = "Show Scope Chain on pause";
Modified: branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Base/Setting.js (271832 => 271833)
--- branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-01-25 22:11:46 UTC (rev 271832)
+++ branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-01-25 22:11:49 UTC (rev 271833)
@@ -223,7 +223,6 @@
experimentalEnablePreviewFeatures: new WI.Setting("experimental-enable-preview-features", true),
experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
- experimentalEnableFontDetailsPanel: new WI.Setting("experimental-font-details-panel", false),
// Protocol
protocolLogAsText: new WI.Setting("protocol-log-as-text", false),
Modified: branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js (271832 => 271833)
--- branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2021-01-25 22:11:46 UTC (rev 271832)
+++ branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2021-01-25 22:11:49 UTC (rev 271833)
@@ -33,7 +33,7 @@
];
// COMPATIBILITY (iOS 14.0): `CSS.getFontDataForNode` did not exist yet.
- if (WI.settings.experimentalEnableFontDetailsPanel.value && InspectorBackend.hasCommand("CSS.getFontDataForNode"))
+ if (InspectorBackend.hasCommand("CSS.getFontDataForNode"))
detailsSidebarPanelConstructors.push(WI.FontDetailsSidebarPanel);
detailsSidebarPanelConstructors.push(WI.ChangesDetailsSidebarPanel, WI.DOMNodeDetailsSidebarPanel);
if (InspectorBackend.hasDomain("LayerTree"))
Modified: branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (271832 => 271833)
--- branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-01-25 22:11:46 UTC (rev 271832)
+++ branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-01-25 22:11:49 UTC (rev 271833)
@@ -402,10 +402,6 @@
experimentalSettingsView.addSeparator();
}
- let elementsGroup = experimentalSettingsView.addGroup(WI.UIString("Elements Tab:", "Elements Tab: @ Experimental Settings", "Category label for experimental settings pertaining to the Elements tab"));
- elementsGroup.addSetting(WI.settings.experimentalEnableFontDetailsPanel, WI.UIString("Show Font details sidebar panel"));
- experimentalSettingsView.addSeparator();
-
let reloadInspectorButton = document.createElement("button");
reloadInspectorButton.textContent = WI.UIString("Reload Web Inspector");
reloadInspectorButton.addEventListener("click", (event) => {
@@ -429,8 +425,6 @@
listenForChange(WI.settings.experimentalEnableStylesJumpToVariableDeclaration);
}
- listenForChange(WI.settings.experimentalEnableFontDetailsPanel);
-
this._createReferenceLink(experimentalSettingsView);
this.addSettingsView(experimentalSettingsView);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
