Title: [271854] branches/safari-611-branch/Source/WebCore
- Revision
- 271854
- Author
- alanc...@apple.com
- Date
- 2021-01-25 14:13:28 -0800 (Mon, 25 Jan 2021)
Log Message
Cherry-pick r271589. rdar://problem/73477370
Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
https://bugs.webkit.org/show_bug.cgi?id=220672
<rdar://problem/73045466>
Reviewed by Darin Adler.
The call to AccessibilityObject::setFocused to set the focus to the
scroll view needs to happen before the check for canSetFocusAttribute.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setFocused):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611-branch/Source/WebCore/ChangeLog (271853 => 271854)
--- branches/safari-611-branch/Source/WebCore/ChangeLog 2021-01-25 22:13:21 UTC (rev 271853)
+++ branches/safari-611-branch/Source/WebCore/ChangeLog 2021-01-25 22:13:28 UTC (rev 271854)
@@ -1,5 +1,38 @@
2021-01-25 Alan Coon <alanc...@apple.com>
+ Cherry-pick r271589. rdar://problem/73477370
+
+ Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
+ https://bugs.webkit.org/show_bug.cgi?id=220672
+ <rdar://problem/73045466>
+
+ Reviewed by Darin Adler.
+
+ The call to AccessibilityObject::setFocused to set the focus to the
+ scroll view needs to happen before the check for canSetFocusAttribute.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::setFocused):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-18 Andres Gonzalez <andresg...@apple.com>
+
+ Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
+ https://bugs.webkit.org/show_bug.cgi?id=220672
+ <rdar://problem/73045466>
+
+ Reviewed by Darin Adler.
+
+ The call to AccessibilityObject::setFocused to set the focus to the
+ scroll view needs to happen before the check for canSetFocusAttribute.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::setFocused):
+
+2021-01-25 Alan Coon <alanc...@apple.com>
+
Cherry-pick r271587. rdar://problem/73477379
Fix for LayoutTests/accessibility/canvas-fallback-content.html in isolated tree mode.
Modified: branches/safari-611-branch/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (271853 => 271854)
--- branches/safari-611-branch/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2021-01-25 22:13:21 UTC (rev 271853)
+++ branches/safari-611-branch/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2021-01-25 22:13:28 UTC (rev 271854)
@@ -1847,6 +1847,9 @@
void AccessibilityRenderObject::setFocused(bool on)
{
+ // Call the base class setFocused to ensure the view is focused and active.
+ AccessibilityObject::setFocused(on);
+
if (!canSetFocusAttribute())
return;
@@ -1858,9 +1861,6 @@
return;
}
- // Call the base class setFocused to ensure the view is focused and active.
- AccessibilityObject::setFocused(on);
-
// When a node is told to set focus, that can cause it to be deallocated, which means that doing
// anything else inside this object will crash. To fix this, we added a RefPtr to protect this object
// long enough for duration.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
